Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2649)

Unified Diff: Source/platform/image-decoders/bmp/BMPImageDecoder.h

Issue 556913002: Use reference instead of pointer in BMPImageDecoder::processFileHeader (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Assert removed Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/platform/image-decoders/bmp/BMPImageDecoder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/image-decoders/bmp/BMPImageDecoder.h
diff --git a/Source/platform/image-decoders/bmp/BMPImageDecoder.h b/Source/platform/image-decoders/bmp/BMPImageDecoder.h
index ccac03fcbb4935b58568fc4c8af4dbc7bfa6daad..21e4fd0790cff6b76e4b89c361fc596eb8d20403 100644
--- a/Source/platform/image-decoders/bmp/BMPImageDecoder.h
+++ b/Source/platform/image-decoders/bmp/BMPImageDecoder.h
@@ -58,18 +58,18 @@ private:
}
// Decodes the image. If |onlySize| is true, stops decoding after
- // calculating the image size. If decoding fails but there is no more
+ // calculating the image size. If decoding fails but there is no more
// data coming, sets the "decode failure" flag.
void decode(bool onlySize);
// Decodes the image. If |onlySize| is true, stops decoding after
- // calculating the image size. Returns whether decoding succeeded.
+ // calculating the image size. Returns whether decoding succeeded.
bool decodeHelper(bool onlySize);
// Processes the file header at the beginning of the data. Sets
- // |*imgDataOffset| based on the header contents. Returns true if the
+ // |imgDataOffset| based on the header contents. Returns true if the
// file header could be decoded.
- bool processFileHeader(size_t* imgDataOffset);
+ bool processFileHeader(size_t& imgDataOffset);
// An index into |m_data| representing how much we've already decoded.
// Note that this only tracks data _this_ class decodes; once the
« no previous file with comments | « no previous file | Source/platform/image-decoders/bmp/BMPImageDecoder.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698