content/browser/frame_host/render_frame_host_impl.cc - Issue 556703004: Remove page id from FrameNavigateParams.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 556703004: Remove page id from FrameNavigateParams. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: cleaner Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/render_frame_host_impl.cc

diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc

index d21b8432665d89c035e8e0a2d362a62f810313cc..8cb261dd3bf557d901233780f58fa81d6f103743 100644

--- a/content/browser/frame_host/render_frame_host_impl.cc

+++ b/content/browser/frame_host/render_frame_host_impl.cc

@@ -671,7 +671,8 @@ void RenderFrameHostImpl::OnDidCommitProvisionalLoad(const IPC::Message& msg) {

return;

}

- frame_tree_node()->navigator()->DidNavigate(this, validated_params);

+ frame_tree_node()->navigator()->DidNavigate(

+ this, render_view_host_->page_id_, validated_params);

Charlie Reis 2014/09/11 22:55:39 Yes, I think having the page ID on the RVH should

}

RenderWidgetHostImpl* RenderFrameHostImpl::GetRenderWidgetHost() {