Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Unified Diff: content/browser/frame_host/render_frame_host_manager_unittest.cc

Issue 556703004: Remove page id from FrameNavigateParams. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: cleaner Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_manager_unittest.cc
diff --git a/content/browser/frame_host/render_frame_host_manager_unittest.cc b/content/browser/frame_host/render_frame_host_manager_unittest.cc
index 00164a12e268614e7c62621e4e2276ecc5f3ade7..7fc75820781d98b0785e8dcfb8f72206ed9e72c1 100644
--- a/content/browser/frame_host/render_frame_host_manager_unittest.cc
+++ b/content/browser/frame_host/render_frame_host_manager_unittest.cc
@@ -1015,7 +1015,6 @@ TEST_F(RenderFrameHostManagerTest, PageDoesBackAndReload) {
// Before that RFH has committed, the evil page reloads itself.
FrameHostMsg_DidCommitProvisionalLoad_Params params;
- params.page_id = 1;
params.url = kUrl2;
params.transition = PAGE_TRANSITION_CLIENT_REDIRECT;
params.should_update_history = false;
@@ -1024,7 +1023,7 @@ TEST_F(RenderFrameHostManagerTest, PageDoesBackAndReload) {
params.is_post = false;
params.page_state = PageState::CreateFromURL(kUrl2);
- contents()->GetFrameTree()->root()->navigator()->DidNavigate(evil_rfh,
+ contents()->GetFrameTree()->root()->navigator()->DidNavigate(evil_rfh, 1,
params);
// That should have cancelled the pending RFH, and the evil RFH should be the

Powered by Google App Engine
This is Rietveld 408576698