Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 556703004: Remove page id from FrameNavigateParams. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: cleaner Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/frame_host/render_frame_host_impl.h" 5 #include "content/browser/frame_host/render_frame_host_impl.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/containers/hash_tables.h" 9 #include "base/containers/hash_tables.h"
10 #include "base/debug/crash_logging.h" 10 #include "base/debug/crash_logging.h"
(...skipping 653 matching lines...) Expand 10 before | Expand all | Expand 10 after
664 process->FilterURL(true, &validated_params.searchable_form_url); 664 process->FilterURL(true, &validated_params.searchable_form_url);
665 665
666 // Without this check, the renderer can trick the browser into using 666 // Without this check, the renderer can trick the browser into using
667 // filenames it can't access in a future session restore. 667 // filenames it can't access in a future session restore.
668 if (!render_view_host_->CanAccessFilesOfPageState( 668 if (!render_view_host_->CanAccessFilesOfPageState(
669 validated_params.page_state)) { 669 validated_params.page_state)) {
670 GetProcess()->ReceivedBadMessage(); 670 GetProcess()->ReceivedBadMessage();
671 return; 671 return;
672 } 672 }
673 673
674 frame_tree_node()->navigator()->DidNavigate(this, validated_params); 674 frame_tree_node()->navigator()->DidNavigate(
675 this, render_view_host_->page_id_, validated_params);
Charlie Reis 2014/09/11 22:55:39 Yes, I think having the page ID on the RVH should
675 } 676 }
676 677
677 RenderWidgetHostImpl* RenderFrameHostImpl::GetRenderWidgetHost() { 678 RenderWidgetHostImpl* RenderFrameHostImpl::GetRenderWidgetHost() {
678 return static_cast<RenderWidgetHostImpl*>(render_view_host_); 679 return static_cast<RenderWidgetHostImpl*>(render_view_host_);
679 } 680 }
680 681
681 int RenderFrameHostImpl::GetEnabledBindings() { 682 int RenderFrameHostImpl::GetEnabledBindings() {
682 return render_view_host_->GetEnabledBindings(); 683 return render_view_host_->GetEnabledBindings();
683 } 684 }
684 685
(...skipping 680 matching lines...) Expand 10 before | Expand all | Expand 10 after
1365 // Clear any state if a pending navigation is canceled or preempted. 1366 // Clear any state if a pending navigation is canceled or preempted.
1366 if (suspended_nav_params_) 1367 if (suspended_nav_params_)
1367 suspended_nav_params_.reset(); 1368 suspended_nav_params_.reset();
1368 1369
1369 TRACE_EVENT_ASYNC_END0("navigation", 1370 TRACE_EVENT_ASYNC_END0("navigation",
1370 "RenderFrameHostImpl navigation suspended", this); 1371 "RenderFrameHostImpl navigation suspended", this);
1371 navigations_suspended_ = false; 1372 navigations_suspended_ = false;
1372 } 1373 }
1373 1374
1374 } // namespace content 1375 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698