Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 55653003: Rename TextTrackRegion/TextTrackRegionList to VTTRegion/VTTRegionList (Closed)

Created:
7 years, 1 month ago by philipj_slow
Modified:
7 years, 1 month ago
CC:
blink-reviews, nessy, arv+blink, gavinp+loader_chromium.org, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, Nate Chapin, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Rename TextTrackRegion/TextTrackRegionList to VTTRegion/VTTRegionList http://dev.w3.org/html5/webvtt/#vttregion-interface http://dev.w3.org/html5/webvtt/#vttregionlist-interface This is a completely mechanical rename, except for added instanceof tests and removing NoInterfaceObject (not per spec) from VTTRegionList to make them pass. Silvia (the spec editor) says in the bug that the spec hasn't changed since the implementation, so together with the fact that this is RuntimeEnabled, it should be safe despite being Web facing. BUG=313604 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161209

Patch Set 1 #

Total comments: 2

Patch Set 2 : update test expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -1688 lines) Patch
M LayoutTests/media/track/regions-webvtt/text-track-cue-region-attribute.html View 1 chunk +1 line, -1 line 0 comments Download
D LayoutTests/media/track/regions-webvtt/text-track-region-constructor.html View 1 chunk +0 lines, -77 lines 0 comments Download
D LayoutTests/media/track/regions-webvtt/text-track-region-constructor-expected.txt View 1 chunk +0 lines, -120 lines 0 comments Download
D LayoutTests/media/track/regions-webvtt/text-track-region-display.html View 1 chunk +0 lines, -108 lines 0 comments Download
D LayoutTests/media/track/regions-webvtt/text-track-region-display-expected.txt View 1 chunk +0 lines, -52 lines 0 comments Download
D LayoutTests/media/track/regions-webvtt/text-track-region-dom-layout.html View 1 chunk +0 lines, -64 lines 0 comments Download
D LayoutTests/media/track/regions-webvtt/text-track-region-dom-layout-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/media/track/regions-webvtt/text-track-region-list.html View 1 chunk +0 lines, -98 lines 0 comments Download
D LayoutTests/media/track/regions-webvtt/text-track-region-list-expected.txt View 1 chunk +0 lines, -41 lines 0 comments Download
D LayoutTests/media/track/regions-webvtt/text-track-region-parser.html View 1 chunk +0 lines, -66 lines 0 comments Download
D LayoutTests/media/track/regions-webvtt/text-track-region-parser-expected.txt View 1 chunk +0 lines, -28 lines 0 comments Download
A + LayoutTests/media/track/regions-webvtt/vtt-region-constructor.html View 2 chunks +6 lines, -3 lines 0 comments Download
A + LayoutTests/media/track/regions-webvtt/vtt-region-constructor-expected.txt View 1 chunk +3 lines, -1 line 0 comments Download
A + LayoutTests/media/track/regions-webvtt/vtt-region-display.html View 2 chunks +2 lines, -2 lines 0 comments Download
A + LayoutTests/media/track/regions-webvtt/vtt-region-display-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/media/track/regions-webvtt/vtt-region-dom-layout.html View 2 chunks +2 lines, -2 lines 0 comments Download
A + LayoutTests/media/track/regions-webvtt/vtt-region-dom-layout-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/media/track/regions-webvtt/vtt-region-list.html View 4 chunks +8 lines, -5 lines 0 comments Download
A + LayoutTests/media/track/regions-webvtt/vtt-region-list-expected.txt View 1 chunk +6 lines, -3 lines 0 comments Download
A + LayoutTests/media/track/regions-webvtt/vtt-region-parser.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/media/track/regions-webvtt/vtt-region-parser-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M LayoutTests/webexposed/global-constructors-listing-expected.txt View 1 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/core.gypi View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/html/shadow/MediaControlElements.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/track/LoadableTextTrack.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/track/TextTrack.h View 3 chunks +7 lines, -7 lines 0 comments Download
M Source/core/html/track/TextTrack.cpp View 4 chunks +12 lines, -12 lines 0 comments Download
M Source/core/html/track/TextTrack.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/track/TextTrackCue.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
D Source/core/html/track/TextTrackRegion.h View 1 chunk +0 lines, -154 lines 0 comments Download
D Source/core/html/track/TextTrackRegion.cpp View 1 chunk +0 lines, -503 lines 0 comments Download
D Source/core/html/track/TextTrackRegion.idl View 1 chunk +0 lines, -42 lines 0 comments Download
D Source/core/html/track/TextTrackRegionList.h View 1 chunk +0 lines, -62 lines 0 comments Download
D Source/core/html/track/TextTrackRegionList.cpp View 1 chunk +0 lines, -81 lines 0 comments Download
D Source/core/html/track/TextTrackRegionList.idl View 1 chunk +0 lines, -35 lines 0 comments Download
A + Source/core/html/track/VTTRegion.h View 5 chunks +10 lines, -10 lines 0 comments Download
A + Source/core/html/track/VTTRegion.cpp View 27 chunks +41 lines, -41 lines 0 comments Download
A + Source/core/html/track/VTTRegion.idl View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/html/track/VTTRegionList.h View 1 chunk +13 lines, -13 lines 0 comments Download
A + Source/core/html/track/VTTRegionList.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
A + Source/core/html/track/VTTRegionList.idl View 1 chunk +3 lines, -4 lines 0 comments Download
M Source/core/html/track/WebVTTParser.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/track/WebVTTParser.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/loader/TextTrackLoader.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/TextTrackLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
philipj_slow
Requesting review from Aaron and rubber stamping from Adam.
7 years, 1 month ago (2013-11-01 13:01:33 UTC) #1
vcarbune.chromium
On 2013/11/01 13:01:33, philipj wrote: > Requesting review from Aaron and rubber stamping from Adam. ...
7 years, 1 month ago (2013-11-01 13:06:33 UTC) #2
philipj_slow
On 2013/11/01 13:06:33, vcarbune.chromium wrote: > On 2013/11/01 13:01:33, philipj wrote: > > Requesting review ...
7 years, 1 month ago (2013-11-01 14:36:13 UTC) #3
adamk
You'll need a more powerful rubber-stamper than I (since you're touching .idl files and thus ...
7 years, 1 month ago (2013-11-01 15:13:00 UTC) #4
acolwell GONE FROM CHROMIUM
lgtm https://codereview.chromium.org/55653003/diff/1/Source/core/html/track/VTTRegionList.idl File Source/core/html/track/VTTRegionList.idl (left): https://codereview.chromium.org/55653003/diff/1/Source/core/html/track/VTTRegionList.idl#oldcode29 Source/core/html/track/VTTRegionList.idl:29: RuntimeEnabled=WebVTTRegions Consider adding a , depends_on=VideoTrack for WebVTTRegions ...
7 years, 1 month ago (2013-11-01 19:32:48 UTC) #5
ojan
lgtm
7 years, 1 month ago (2013-11-01 22:05:14 UTC) #6
philipj_slow
https://codereview.chromium.org/55653003/diff/1/Source/core/html/track/VTTRegionList.idl File Source/core/html/track/VTTRegionList.idl (left): https://codereview.chromium.org/55653003/diff/1/Source/core/html/track/VTTRegionList.idl#oldcode29 Source/core/html/track/VTTRegionList.idl:29: RuntimeEnabled=WebVTTRegions On 2013/11/01 19:32:49, acolwell wrote: > Consider adding ...
7 years, 1 month ago (2013-11-01 22:06:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/55653003/90001
7 years, 1 month ago (2013-11-01 22:07:07 UTC) #8
commit-bot: I haz the power
7 years, 1 month ago (2013-11-01 23:37:59 UTC) #9
Message was sent while issue was closed.
Change committed as 161209

Powered by Google App Engine
This is Rietveld 408576698