LayoutTests/media/track/regions-webvtt/vtt-region-list.html - Issue 55653003: Rename TextTrackRegion/TextTrackRegionList to VTTRegion/VTTRegionList

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/media/track/regions-webvtt/vtt-region-list.html

Issue 55653003: Rename TextTrackRegion/TextTrackRegionList to VTTRegion/VTTRegionList (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: update test expectations Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/media/track/regions-webvtt/vtt-region-dom-layout-expected.txt ('k') | LayoutTests/media/track/regions-webvtt/vtt-region-list-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/media/track/regions-webvtt/vtt-region-list.html

diff --git a/LayoutTests/media/track/regions-webvtt/text-track-region-list.html b/LayoutTests/media/track/regions-webvtt/vtt-region-list.html

similarity index 90%

rename from LayoutTests/media/track/regions-webvtt/text-track-region-list.html

rename to LayoutTests/media/track/regions-webvtt/vtt-region-list.html

index 976e066800cfe308c3eb7e48f3f53b8fdc01e3a2..a3c19c7b6f4ef134e4adb98688127d38b14fa00a 100644

--- a/LayoutTests/media/track/regions-webvtt/text-track-region-list.html

+++ b/LayoutTests/media/track/regions-webvtt/vtt-region-list.html

@@ -22,11 +22,14 @@

testTrack.track.mode = "hidden";

regions = testTrack.track.regions;

- consoleWrite(" ** The regions attribute should be an empty TextTrackRegionList **");

+ consoleWrite(" ** Test instanceof VTTRegionList **");

+ testExpected("regions instanceof VTTRegionList", true);

+ consoleWrite(" ** The regions attribute should be an empty VTTRegionList **");

testExpected("regions != null", true);

testExpected("regions.length", 0);

- region = new TextTrackRegion();

+ region = new VTTRegion();

region.id = "TestId";

consoleWrite(" ** The default value of the track attribute of the region is null**");

@@ -34,7 +37,7 @@

testTrack.track.addRegion(region);

- consoleWrite(" ** The addRegion() method properly updates the TextTrackRegionList object **");

+ consoleWrite(" ** The addRegion() method properly updates the VTTRegionList object **");

testExpected("regions.length", 1);

testExpected("regions[0] == region", true);

testExpected("regions[0].track == testTrack.track", true);

@@ -42,7 +45,7 @@

consoleWrite(" ** The track attribute should correctly reflect the track to which the region was added to**");

testExpected("region.track == testTrack.track", true);

- updatedRegion = new TextTrackRegion();

+ updatedRegion = new VTTRegion();

updatedRegion.id = region.id;

updatedRegion.viewportAnchorX = 59;

updatedRegion.viewportAnchorY = 68;

@@ -90,7 +93,7 @@

</script>

</head>

- Tests TextTrackRegionList functionality: length, operator[], and getRegionById()

+ Tests VTTRegionList functionality: length, operator[], and getRegionById()

<video>

</video>