Source/core/html/track/WebVTTParser.cpp - Issue 55653003: Rename TextTrackRegion/TextTrackRegionList to VTTRegion/VTTRegionList

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/track/WebVTTParser.cpp

Issue 55653003: Rename TextTrackRegion/TextTrackRegionList to VTTRegion/VTTRegionList (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: update test expectations Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/track/WebVTTParser.cpp

diff --git a/Source/core/html/track/WebVTTParser.cpp b/Source/core/html/track/WebVTTParser.cpp

index 32d0bbe90e08fc1bee88d55c93e3cb4a9f67f03c..59b4115d748e5912e9140f2f88d989438ead0b87 100644

--- a/Source/core/html/track/WebVTTParser.cpp

+++ b/Source/core/html/track/WebVTTParser.cpp

@@ -126,7 +126,7 @@ void WebVTTParser::getNewCues(Vector<RefPtr<TextTrackCue> >& outputCues)

m_cuelist.clear();

}

-void WebVTTParser::getNewRegions(Vector<RefPtr<TextTrackRegion> >& outputRegions)

+void WebVTTParser::getNewRegions(Vector<RefPtr<VTTRegion> >& outputRegions)

{

outputRegions = m_regionList;

m_regionList.clear();

@@ -376,7 +376,7 @@ void WebVTTParser::createNewRegion()

if (!m_currentHeaderValue.length())

return;

- RefPtr<TextTrackRegion> region = TextTrackRegion::create();

+ RefPtr<VTTRegion> region = VTTRegion::create();

region->setRegionSettings(m_currentHeaderValue);

// 15.5.10 If the text track list of regions regions contains a region

« no previous file with comments | « Source/core/html/track/WebVTTParser.h ('k') | Source/core/loader/TextTrackLoader.h » ('j') | no next file with comments »