Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 555283004: [turbofan] Next step towards shared operators. (Closed)

Created:
6 years, 3 months ago by Benedikt Meurer
Modified:
6 years, 3 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Next step towards shared operators. TEST=compiler-unittests,cctest R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23837

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+432 lines, -396 lines) Patch
M src/compiler/ast-graph-builder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ast-graph-builder.cc View 41 chunks +44 lines, -43 lines 0 comments Download
M src/compiler/change-lowering.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/compiler/common-operator.h View 1 chunk +27 lines, -26 lines 0 comments Download
M src/compiler/common-operator-unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/graph-builder.h View 3 chunks +13 lines, -12 lines 0 comments Download
M src/compiler/graph-builder.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M src/compiler/js-context-specialization.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M src/compiler/js-generic-lowering.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-graph.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-graph.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-inlining.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/compiler/js-operator.h View 2 chunks +61 lines, -54 lines 0 comments Download
M src/compiler/js-typed-lowering.h View 1 chunk +4 lines, -3 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 8 chunks +12 lines, -10 lines 0 comments Download
M src/compiler/machine-operator.h View 2 chunks +74 lines, -73 lines 0 comments Download
M src/compiler/machine-operator-reducer-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/machine-operator-unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/raw-machine-assembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/representation-change.h View 7 chunks +7 lines, -7 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +37 lines, -33 lines 0 comments Download
M src/compiler/simplified-operator-reducer.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/simplified-operator-reducer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/simplified-operator-reducer-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/codegen-tester.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/graph-builder-tester.h View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/compiler/simplified-graph-builder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/compiler/simplified-graph-builder.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/compiler/test-changes-lowering.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 22 chunks +33 lines, -32 lines 0 comments Download
M test/cctest/compiler/test-machine-operator-reducer.cc View 4 chunks +10 lines, -9 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 12 chunks +33 lines, -26 lines 0 comments Download
M test/cctest/compiler/test-scheduler.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 7 chunks +17 lines, -17 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
6 years, 3 months ago (2014-09-10 08:55:18 UTC) #1
Sven Panne
LGTM (mostly rubberstamped)
6 years, 3 months ago (2014-09-10 10:16:03 UTC) #2
Benedikt Meurer
6 years, 3 months ago (2014-09-10 12:24:14 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 23837 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698