Add hung bots to sheriff-o-matic view

Add hung bots to sheriff-o-matic view

Add another category of failure cards that display bots that have
been running or offline over a threshold of time. This is special-
cased for chromium.webkit & blink to start.

Also removing ct-revision-details since it's effectively obsoleted
by this change.

BUG=399957
NOTRY=true

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181700

[leviw_travelin_and_unemployed, 2014-09-10 00:11:53]

leviw@chromium.org changed reviewers:
+ ojan@chromium.org

[ojan, 2014-09-10 00:40:03]

https://codereview.chromium.org/555263004/diff/20001/Tools/GardeningServer/mo...
File Tools/GardeningServer/model/ct-builder-failure-group-data.html (right):

https://codereview.chromium.org/555263004/diff/20001/Tools/GardeningServer/mo...
Tools/GardeningServer/model/ct-builder-failure-group-data.html:19:
CTBuilderFailureGroupData.prototype.dataToExamine = function() {
This needs to go. Not as part of this patch, but a FIXME would be nice. We
should just pass the CT*FailureGroupData directly to the appropriate results
pane instead of creating this unnecessary, untyped object.

https://codereview.chromium.org/555263004/diff/20001/Tools/GardeningServer/mo...
File Tools/GardeningServer/model/ct-builder.html (right):

https://codereview.chromium.org/555263004/diff/20001/Tools/GardeningServer/mo...
Tools/GardeningServer/model/ct-builder.html:14: masterUrl,
encodeURIComponent(builder));
This should be indented 4 spaces.

https://codereview.chromium.org/555263004/diff/20001/Tools/GardeningServer/mo...
File Tools/GardeningServer/model/ct-failures.html (right):

https://codereview.chromium.org/555263004/diff/20001/Tools/GardeningServer/mo...
Tools/GardeningServer/model/ct-failures.html:100: this.builderLatestInfo[master]
= new CTBuilderRevisions(data);
Do we need CTBuilderRevisions at all anymore? Can we just pass
latest_builder_info to _checkBuildersForFailures and not store anything else on
CTFailures?

lgtm for this patch assuming you add the FIXMEs and fix this bit.

https://codereview.chromium.org/555263004/diff/20001/Tools/GardeningServer/mo...
Tools/GardeningServer/model/ct-failures.html:217:
Object.keys(this.builderLatestInfo, function(master, builders) {
In retrospect, we should move all this logic to builder_alerts and just have the
JSON contain the actual alerting things. That way, in theory, people can write
other tools that do something with the alerts. This would also solve the problem
of matching the master name to a tree since we have this data in builder_alerts.

You don't need to do that in this patch if you don't want to though. If you
wanted...you could have this patch form the JSON in the form you want it from
builder_alerts and then in a followup patch move the generation of that to
builder_alerts.

https://codereview.chromium.org/555263004/diff/20001/Tools/GardeningServer/ui...
File Tools/GardeningServer/ui/ct-failure-card.html (right):

https://codereview.chromium.org/555263004/diff/20001/Tools/GardeningServer/ui...
Tools/GardeningServer/ui/ct-failure-card.html:71: <template if="{{
group.data.category == 'sheriff' }}">
Please add FIXME to do the refactoring to move the buttons into their own thing
so that we don't need to have failure-card contain other failure cards.

https://codereview.chromium.org/555263004/diff/20001/Tools/GardeningServer/ui...
File Tools/GardeningServer/ui/ct-unexpected-failures.html (right):

https://codereview.chromium.org/555263004/diff/20001/Tools/GardeningServer/ui...
Tools/GardeningServer/ui/ct-unexpected-failures.html:39: background-color:
papayawhip;
<3 papayawhip

[leviw_travelin_and_unemployed, 2014-09-10 04:34:11]

The CQ bit was checked by leviw@chromium.org

[commit-bot: I haz the power, 2014-09-10 04:35:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/leviw@chromium.org/555263004/40001

[commit-bot: I haz the power, 2014-09-10 04:35:46]

Committed patchset #3 (id:40001) as 181700