Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Side by Side Diff: Tools/GardeningServer/ui/ct-results-detail.html

Issue 555263004: Add hung bots to sheriff-o-matic view (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Address nits. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 <!-- 1 <!--
2 Copyright 2014 The Chromium Authors. All rights reserved. 2 Copyright 2014 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. 4 found in the LICENSE file.
5 --> 5 -->
6 6
7 <link rel="import" href="ct-results-comparison.html"> 7 <link rel="import" href="ct-results-comparison.html">
8 8
9 <polymer-element name="ct-results-detail" attributes="failure builder"> 9 <polymer-element name="ct-results-detail" attributes="failure builder">
10 <template> 10 <template>
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 _updateUrls: function() { 89 _updateUrls: function() {
90 // FIXME: Along with _updateWebkitTestUrls, move this logic to a proper model class 90 // FIXME: Along with _updateWebkitTestUrls, move this logic to a proper model class
91 // so that the network requests this makes can be easily mocked out in t ests. 91 // so that the network requests this makes can be easily mocked out in t ests.
92 92
93 var result = this.failure.resultNodesByBuilder[this.builder]; 93 var result = this.failure.resultNodesByBuilder[this.builder];
94 94
95 // FIXME: We only store build logs by the test name, not the testsuite.t estname, 95 // FIXME: We only store build logs by the test name, not the testsuite.t estname,
96 // which means that two failing tests from different test suites conflic t! 96 // which means that two failing tests from different test suites conflic t!
97 var testPart = result.actual == 'UNKNOWN' ? 'stdio' : this.failure.testN ame.split('.')[1]; 97 var testPart = result.actual == 'UNKNOWN' ? 'stdio' : this.failure.testN ame.split('.')[1];
98 var url = result.masterUrl + 98 var url = result.masterUrl +
99 '/builders/' + encodeURIComponent(this.builder) + 99 '/builders/' + encodeURIComponent(this.builder);
100
101 // FIXME: Make failure groups aware of their own url
102 if (this.failure.testName)
103 url +=
100 '/builds/' + result.lastFailingBuild + 104 '/builds/' + result.lastFailingBuild +
101 '/steps/' + this.failure.step + 105 '/steps/' + this.failure.step +
102 '/logs/' + testPart; 106 '/logs/' + testPart;
103 107
104 var resultsUrlsByKind = {}; 108 var resultsUrlsByKind = {};
105 resultsUrlsByKind[this._kUnknownKind] = url; 109 resultsUrlsByKind[this._kUnknownKind] = url;
106 110
107 this._urlGroups.push({ 111 this._urlGroups.push({
108 type: results.kTextType, 112 type: results.kTextType,
109 urls: resultsUrlsByKind, 113 urls: resultsUrlsByKind,
110 }); 114 });
111 }, 115 },
112 }); 116 });
113 </script> 117 </script>
114 </polymer-element> 118 </polymer-element>
OLDNEW
« no previous file with comments | « Tools/GardeningServer/ui/ct-failure-card.html ('k') | Tools/GardeningServer/ui/ct-revision-details.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698