Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1796)

Unified Diff: Tools/GardeningServer/ui/ct-results-detail.html

Issue 555263004: Add hung bots to sheriff-o-matic view (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Address nits. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Tools/GardeningServer/ui/ct-failure-card.html ('k') | Tools/GardeningServer/ui/ct-revision-details.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/GardeningServer/ui/ct-results-detail.html
diff --git a/Tools/GardeningServer/ui/ct-results-detail.html b/Tools/GardeningServer/ui/ct-results-detail.html
index 1eef8a14105f66eef37959de6cf394bc4356c3b5..a982e2207869b825debb60647bc9b3b7338bb0cd 100644
--- a/Tools/GardeningServer/ui/ct-results-detail.html
+++ b/Tools/GardeningServer/ui/ct-results-detail.html
@@ -96,7 +96,11 @@ found in the LICENSE file.
// which means that two failing tests from different test suites conflict!
var testPart = result.actual == 'UNKNOWN' ? 'stdio' : this.failure.testName.split('.')[1];
var url = result.masterUrl +
- '/builders/' + encodeURIComponent(this.builder) +
+ '/builders/' + encodeURIComponent(this.builder);
+
+ // FIXME: Make failure groups aware of their own url
+ if (this.failure.testName)
+ url +=
'/builds/' + result.lastFailingBuild +
'/steps/' + this.failure.step +
'/logs/' + testPart;
« no previous file with comments | « Tools/GardeningServer/ui/ct-failure-card.html ('k') | Tools/GardeningServer/ui/ct-revision-details.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698