chrome/browser/resources/options/content_settings_exceptions_area.js - Issue 555163007: Settings: manage location.hash explicitly on a Page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/content_settings_exceptions_area.js

Issue 555163007: Settings: manage location.hash explicitly on a Page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: dbeam comments Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/options/content_settings_exceptions_area.js

diff --git a/chrome/browser/resources/options/content_settings_exceptions_area.js b/chrome/browser/resources/options/content_settings_exceptions_area.js

index 2279c197c523490163be3eea58d60970ba39edba..8a58ff0aebedc273c4a8cde9b23887d00a4b2dfa 100644

--- a/chrome/browser/resources/options/content_settings_exceptions_area.js

+++ b/chrome/browser/resources/options/content_settings_exceptions_area.js

@@ -658,9 +658,8 @@ cr.define('options.contentSettings', function() {

* location's hash.

didShowPage: function() {

- var hash = location.hash;

- if (hash)

- this.showList(hash.slice(1));

+ if (this.hash)

+ this.showList(this.hash.slice(1));

};

« no previous file with comments | « chrome/browser/resources/options/content_settings.js ('k') | chrome/browser/resources/options/options.js » ('j') | no next file with comments »