Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(912)

Unified Diff: chrome/browser/resources/options/content_settings.js

Issue 555163007: Settings: manage location.hash explicitly on a Page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: dbeam comments Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/content_settings.js
diff --git a/chrome/browser/resources/options/content_settings.js b/chrome/browser/resources/options/content_settings.js
index f49b7df7cb51cdf111c8d606e7900c88e1c7c39b..eac4d47f0b8d11ab1338d5cb78551d4c9a26c897 100644
--- a/chrome/browser/resources/options/content_settings.js
+++ b/chrome/browser/resources/options/content_settings.js
@@ -33,17 +33,9 @@ cr.define('options', function() {
this.pageDiv.querySelectorAll('.exceptions-list-button');
for (var i = 0; i < exceptionsButtons.length; i++) {
exceptionsButtons[i].onclick = function(event) {
- var page = ContentSettingsExceptionsArea.getInstance();
-
- // Add on the proper hash for the content type, and store that in the
- // history so back/forward and tab restore works.
var hash = event.currentTarget.getAttribute('contentType');
- var url = page.name + '#' + hash;
- uber.pushState({pageName: page.name}, url);
-
- // Navigate after the local history has been replaced in order to have
- // the correct hash loaded.
- PageManager.showPageByName('contentExceptions', false);
+ PageManager.showPageByName('contentExceptions', true,
+ {hash: '#' + hash});
};
}
« no previous file with comments | « chrome/browser/resources/help/help.js ('k') | chrome/browser/resources/options/content_settings_exceptions_area.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698