chrome/browser/resources/options/options.js - Issue 555163007: Settings: manage location.hash explicitly on a Page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/options.js

Issue 555163007: Settings: manage location.hash explicitly on a Page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: dbeam comments Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/options/content_settings_exceptions_area.js ('k') | chrome/browser/resources/options/search_page.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/options.js

diff --git a/chrome/browser/resources/options/options.js b/chrome/browser/resources/options/options.js

index be478545c3eec70559343f31f2d6091a0a56d0c8..8f119802ddef65b2c5c44b5da88babe97305d7b4 100644

--- a/chrome/browser/resources/options/options.js

+++ b/chrome/browser/resources/options/options.js

@@ -248,7 +248,8 @@ function load() {

// appropriately to chrome://settings/. If the URL matches, updateHistory_

// will avoid the extra replaceState.

var updateHistory = true;

- PageManager.showPageByName(pageName, updateHistory, {replaceState: true});

+ PageManager.showPageByName(pageName, updateHistory,

+ {replaceState: true, hash: location.hash});

var subpagesNavTabs = document.querySelectorAll('.subpages-nav-tabs');

for (var i = 0; i < subpagesNavTabs.length; i++) {

@@ -279,5 +280,5 @@ window.onbeforeunload = function() {

window.onpopstate = function(e) {

var pageName = PageManager.getPageNameFromPath();

- PageManager.setState(pageName, e.state);

+ PageManager.setState(pageName, location.hash, e.state);

};