Fix WeakPtrFactory ordering problems in src/tools

Fix WeakPtrFactory ordering problems in src/tools

Cleaning up weak_ptr_factory destruction order in "src/tools" module.
WeakPtrFactory should remain the last member so it'll be destroyed and
invalidate its weak pointers before any other members are destroyed.

BUG=303818
Committed: https://crrev.com/efd2db86e9ac9e90c8cd2641f188a9c420edf2be
Cr-Commit-Position: refs/heads/master@{#294117}

[anujsharma, 2014-09-09 14:08:02]

anujk.sharma@samsung.com changed reviewers:
+ darin@chromium.org, digit@chromium.org

[anujsharma, 2014-09-09 14:08:03]

digit@chromium.org: Please review changes in src/tools module

darin@chromium.org: Please review changes in rc/tools module

[anujsharma, 2014-09-09 14:08:16]

On 2014/09/09 14:08:03, anujsharma wrote:
> mailto:digit@chromium.org: Please review changes in src/tools module
> 
> mailto:darin@chromium.org: Please review changes in rc/tools module

PTAL

[digit1, 2014-09-09 14:50:00]

lgtm

https://codereview.chromium.org/555093002/diff/1/tools/android/forwarder2/dev...
File tools/android/forwarder2/device_controller.h (right):

https://codereview.chromium.org/555093002/diff/1/tools/android/forwarder2/dev...
tools/android/forwarder2/device_controller.h:60:
base::WeakPtrFactory<DeviceController> weak_ptr_factory_;
lgtm, but you probably want to add a comment here explaining this must be kept
as the last member, to avoid the problem resurfacing later :)

[anujsharma, 2014-09-10 04:58:40]

On 2014/09/09 14:50:00, digit1 wrote:
> lgtm
> 
>
https://codereview.chromium.org/555093002/diff/1/tools/android/forwarder2/dev...
> File tools/android/forwarder2/device_controller.h (right):
> 
>
https://codereview.chromium.org/555093002/diff/1/tools/android/forwarder2/dev...
> tools/android/forwarder2/device_controller.h:60:
> base::WeakPtrFactory<DeviceController> weak_ptr_factory_;
> lgtm, but you probably want to add a comment here explaining this must be kept
> as the last member, to avoid the problem resurfacing later :)

@digit1- Thanks for the lgtm

As suggested i have also kept the comment to explain the WeakPtrFactory
ordering. 
Now proceeding for commit.

Thanks once again :)

[anujsharma, 2014-09-10 04:58:47]

The CQ bit was checked by anujk.sharma@samsung.com

[commit-bot: I haz the power, 2014-09-10 05:01:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/anujk.sharma@samsung.com/555093002/20001

[commit-bot: I haz the power, 2014-09-10 06:09:01]

Committed patchset #2 (id:20001) as c34b424b2ebe4a04dd877678ea25dc496431761b

[commit-bot: I haz the power, 2014-09-10 06:12:00]

Patchset 2 (id:??) landed as
https://crrev.com/efd2db86e9ac9e90c8cd2641f188a9c420edf2be
Cr-Commit-Position: refs/heads/master@{#294117}