OLD | NEW |
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. |
2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
4 | 4 |
5 #ifndef TOOLS_ANDROID_FORWARDER2_DEVICE_CONTROLLER_H_ | 5 #ifndef TOOLS_ANDROID_FORWARDER2_DEVICE_CONTROLLER_H_ |
6 #define TOOLS_ANDROID_FORWARDER2_DEVICE_CONTROLLER_H_ | 6 #define TOOLS_ANDROID_FORWARDER2_DEVICE_CONTROLLER_H_ |
7 | 7 |
8 #include <string> | 8 #include <string> |
9 | 9 |
10 #include "base/basictypes.h" | 10 #include "base/basictypes.h" |
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
42 | 42 |
43 void AcceptHostCommandSoon(); | 43 void AcceptHostCommandSoon(); |
44 void AcceptHostCommandInternal(); | 44 void AcceptHostCommandInternal(); |
45 | 45 |
46 // Note that this can end up being called after the DeviceController is | 46 // Note that this can end up being called after the DeviceController is |
47 // destroyed which is why a weak pointer is used. | 47 // destroyed which is why a weak pointer is used. |
48 static void DeleteListenerOnError( | 48 static void DeleteListenerOnError( |
49 const base::WeakPtr<DeviceController>& device_controller_ptr, | 49 const base::WeakPtr<DeviceController>& device_controller_ptr, |
50 scoped_ptr<DeviceListener> device_listener); | 50 scoped_ptr<DeviceListener> device_listener); |
51 | 51 |
52 base::WeakPtrFactory<DeviceController> weak_ptr_factory_; | |
53 const scoped_ptr<Socket> host_socket_; | 52 const scoped_ptr<Socket> host_socket_; |
54 // Used to notify the controller to exit. | 53 // Used to notify the controller to exit. |
55 const int exit_notifier_fd_; | 54 const int exit_notifier_fd_; |
56 // Lets ensure DeviceListener instances are deleted on the thread they were | 55 // Lets ensure DeviceListener instances are deleted on the thread they were |
57 // created on. | 56 // created on. |
58 const scoped_refptr<base::SingleThreadTaskRunner> construction_task_runner_; | 57 const scoped_refptr<base::SingleThreadTaskRunner> construction_task_runner_; |
59 ListenersMap listeners_; | 58 ListenersMap listeners_; |
60 | 59 |
| 60 //WeakPtrFactory's documentation says: |
| 61 // Member variables should appear before the WeakPtrFactory, to ensure |
| 62 // that any WeakPtrs to Controller are invalidated before its members |
| 63 // variable's destructors are executed, rendering them invalid. |
| 64 base::WeakPtrFactory<DeviceController> weak_ptr_factory_; |
| 65 |
61 DISALLOW_COPY_AND_ASSIGN(DeviceController); | 66 DISALLOW_COPY_AND_ASSIGN(DeviceController); |
62 }; | 67 }; |
63 | 68 |
64 } // namespace forwarder | 69 } // namespace forwarder |
65 | 70 |
66 #endif // TOOLS_ANDROID_FORWARDER2_DEVICE_CONTROLLER_H_ | 71 #endif // TOOLS_ANDROID_FORWARDER2_DEVICE_CONTROLLER_H_ |
OLD | NEW |