tools/android/forwarder2/device_controller.cc - Issue 555093002: Fix WeakPtrFactory ordering problems in src/tools

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/android/forwarder2/device_controller.cc

Issue 555093002: Fix WeakPtrFactory ordering problems in src/tools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added the comment explaining WeakPtrFactory ordering Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/android/forwarder2/device_controller.cc

diff --git a/tools/android/forwarder2/device_controller.cc b/tools/android/forwarder2/device_controller.cc

index 7a4c0ad20eb4fa98c55aea7e517bd8f2690dbf26..a4cb9c75dc37a319eb933cf1de18b6a578163fca 100644

--- a/tools/android/forwarder2/device_controller.cc

+++ b/tools/android/forwarder2/device_controller.cc

@@ -47,10 +47,10 @@ void DeviceController::Start() {

DeviceController::DeviceController(scoped_ptr<Socket> host_socket,

int exit_notifier_fd)

- : weak_ptr_factory_(this),

- host_socket_(host_socket.Pass()),

+ : host_socket_(host_socket.Pass()),

exit_notifier_fd_(exit_notifier_fd),

- construction_task_runner_(base::MessageLoopProxy::current()) {

+ construction_task_runner_(base::MessageLoopProxy::current()),

+ weak_ptr_factory_(this) {

host_socket_->AddEventFd(exit_notifier_fd);

}