SWRegistration::unregister returns false when the registration is already unregistered. (2/3)

ServiceWorkerRegistration::unregister returns false when the registration is already unregistered. (2/3)

1. [Blink] https://codereview.chromium.org/549093002/
2. [Chromium] this patch
3. [Blink] https://codereview.chromium.org/550093002/

BUG=390894
TEST=content_browsertests --gtest_filter='ServiceWorkerBlackBoxBrowserTest.Registration'
TEST=content_unittests --gtest_filter='ServiceWorkerJobTest.Unregister_NothingRegistered'
TEST=content_unittests --gtest_filter='ServiceWorkerJobTest.ParallelUnreg'

Committed: https://crrev.com/903e26ee1682e63d64b4a41036592f3d3d170b5c
Cr-Commit-Position: refs/heads/master@{#294141}

[shimazu, 2014-09-08 08:32:19]

shimazu@chromium.org changed reviewers:
+ horo@chromium.org, kenrb@chromium.org

[shimazu, 2014-09-08 08:32:19]

kenrb@chromium.org: Please review changes in IPC
(content/commmon/service_worker/service_worker_messages.h).

horo@chromium.org: Please review changes in the others.

[kenrb, 2014-09-08 15:34:11]

ipc lgtm

[horo, 2014-09-09 01:24:15]

https://codereview.chromium.org/554573002/diff/1/content/common/service_worke...
File content/common/service_worker/service_worker_messages.h (right):

https://codereview.chromium.org/554573002/diff/1/content/common/service_worke...
content/common/service_worker/service_worker_messages.h:201:
content::ServiceWorkerStatusCode)
We don't need to send the status code.
What we need is a bool value to resolve the promise with true or false.
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#unregister-a...

[shimazu, 2014-09-10 01:22:10]

https://codereview.chromium.org/554573002/diff/1/content/common/service_worke...
File content/common/service_worker/service_worker_messages.h (right):

https://codereview.chromium.org/554573002/diff/1/content/common/service_worke...
content/common/service_worker/service_worker_messages.h:201:
content::ServiceWorkerStatusCode)
On 2014/09/09 01:24:15, horo wrote:
> We don't need to send the status code.
> What we need is a bool value to resolve the promise with true or false.
>
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#unregister-a...

Done.

[horo, 2014-09-10 05:44:43]

lgtm with nit

https://codereview.chromium.org/554573002/diff/20001/content/browser/service_...
File content/browser/service_worker/service_worker_dispatcher_host.cc (right):

https://codereview.chromium.org/554573002/diff/20001/content/browser/service_...
content/browser/service_worker/service_worker_dispatcher_host.cc:602: bool
is_success = (status == SERVICE_WORKER_OK);
nit: const bool

[shimazu, 2014-09-10 06:40:45]

https://codereview.chromium.org/554573002/diff/20001/content/browser/service_...
File content/browser/service_worker/service_worker_dispatcher_host.cc (right):

https://codereview.chromium.org/554573002/diff/20001/content/browser/service_...
content/browser/service_worker/service_worker_dispatcher_host.cc:602: bool
is_success = (status == SERVICE_WORKER_OK);
On 2014/09/10 05:44:43, horo wrote:
> nit: const bool

Done.

[shimazu, 2014-09-10 06:40:57]

The CQ bit was checked by shimazu@chromium.org

[commit-bot: I haz the power, 2014-09-10 06:48:53]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/shimazu@chromium.org/554573002/40001

[commit-bot: I haz the power, 2014-09-10 08:07:54]

Committed patchset #3 (id:40001) as 87faa074f930b354b175baff84e57b0236236eba

[commit-bot: I haz the power, 2014-09-10 10:56:01]

Patchset 3 (id:??) landed as
https://crrev.com/903e26ee1682e63d64b4a41036592f3d3d170b5c
Cr-Commit-Position: refs/heads/master@{#294141}