SWRegistration::unregister returns false when the registration is already unregistered. (2/3)

content/browser/service_worker/service_worker_dispatcher_host.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/service_worker/service_worker_dispatcher_host.h"
 
 #include "base/debug/trace_event.h"
 #include "base/logging.h"
 #include "base/strings/utf_string_conversions.h"
 #include "content/browser/message_port_message_filter.h"
@@ skipping 577 matching lines @@
   }
   handle->DecrementRefCount();
   if (handle->HasNoRefCount())
     registration_handles_.Remove(registration_handle_id);
 }
 
 void ServiceWorkerDispatcherHost::UnregistrationComplete(
     int thread_id,
     int request_id,
     ServiceWorkerStatusCode status) {
-  if (status != SERVICE_WORKER_OK) {
+  if (status != SERVICE_WORKER_OK && status != SERVICE_WORKER_ERROR_NOT_FOUND) {
     SendUnregistrationError(thread_id, request_id, status);
     return;
   }
-
-  Send(new ServiceWorkerMsg_ServiceWorkerUnregistered(thread_id, request_id));
+  bool is_success = (status == SERVICE_WORKER_OK);

[horo, 2014/09/10 05:44:43]

nit: const bool

[shimazu, 2014/09/10 06:40:45]

Done.

+  Send(new ServiceWorkerMsg_ServiceWorkerUnregistered(thread_id,
+                                                      request_id,
+                                                      is_success));
   TRACE_EVENT_ASYNC_END1(
       "ServiceWorker",
       "ServiceWorkerDispatcherHost::UnregisterServiceWorker",
       request_id,
       "Status", status);
 }
 
 void ServiceWorkerDispatcherHost::SendRegistrationError(
     int thread_id,
     int request_id,
@@ skipping 16 matching lines @@
       status, &error_type, &error_message);
   Send(new ServiceWorkerMsg_ServiceWorkerUnregistrationError(
       thread_id, request_id, error_type, error_message));
 }
 
 ServiceWorkerContextCore* ServiceWorkerDispatcherHost::GetContext() {
   return context_wrapper_->context();
 }
 
 }  // namespace content