content/child/service_worker/service_worker_dispatcher.cc - Issue 554573002: SWRegistration::unregister returns false when the registration is already unregistered. (2/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/service_worker/service_worker_dispatcher.cc

Issue 554573002: SWRegistration::unregister returns false when the registration is already unregistered. (2/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add const Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/child/service_worker/service_worker_dispatcher.h ('k') | content/common/service_worker/service_worker_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/service_worker/service_worker_dispatcher.cc

diff --git a/content/child/service_worker/service_worker_dispatcher.cc b/content/child/service_worker/service_worker_dispatcher.cc

index 832a171977886761d80378646c7a23bcfd959483..d4e404b1414e83279f7768105b80f0cd51dc24b5 100644

--- a/content/child/service_worker/service_worker_dispatcher.cc

+++ b/content/child/service_worker/service_worker_dispatcher.cc

@@ -277,9 +277,9 @@ void ServiceWorkerDispatcher::OnRegistered(

request_id);

}

-void ServiceWorkerDispatcher::OnUnregistered(

- int thread_id,

- int request_id) {

+void ServiceWorkerDispatcher::OnUnregistered(int thread_id,

+ int request_id,

+ bool is_success) {

WebServiceWorkerUnregistrationCallbacks* callbacks =

pending_unregistration_callbacks_.Lookup(request_id);

TRACE_EVENT_ASYNC_STEP_INTO0(

@@ -290,7 +290,6 @@ void ServiceWorkerDispatcher::OnUnregistered(

DCHECK(callbacks);

if (!callbacks)

return;

- bool is_success = true;

callbacks->onSuccess(&is_success);

pending_unregistration_callbacks_.Remove(request_id);

TRACE_EVENT_ASYNC_END0("ServiceWorker",