components/suggestions/suggestions_service.h - Issue 554233002: Refactoring the WeakPtrFactory usage, Member variables should appear before the WeakPtrFactory, to …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/suggestions/suggestions_service.h

Issue 554233002: Refactoring the WeakPtrFactory usage, Member variables should appear before the WeakPtrFactory, to … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/storage_monitor/portable_device_watcher_win.h ('K') | « components/storage_monitor/portable_device_watcher_win.h ('k') | components/suggestions/suggestions_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/suggestions/suggestions_service.h

diff --git a/components/suggestions/suggestions_service.h b/components/suggestions/suggestions_service.h

index e495f7f8aac23fd5dc46fd541355be7027e45097..aa30ba2554f92bf923bdbefb0e33a4d62c75d18a 100644

--- a/components/suggestions/suggestions_service.h

+++ b/components/suggestions/suggestions_service.h

@@ -188,13 +188,13 @@ class SuggestionsService : public KeyedService, public net::URLFetcherDelegate {

// Delay used when scheduling a blacklisting task.

int blacklist_delay_sec_;

- // For callbacks may be run after destruction.

- base::WeakPtrFactory<SuggestionsService> weak_ptr_factory_;

// Timeout (in ms) before serving requestors after a fetch suggestions request

// has been issued.

int request_timeout_ms_;

+ // For callbacks may be run after destruction.

+ base::WeakPtrFactory<SuggestionsService> weak_ptr_factory_;

DISALLOW_COPY_AND_ASSIGN(SuggestionsService);

};