Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 553903003: Refactor IsolateHolder to be able to always create the isolate (Closed)

Created:
6 years, 3 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 3 months ago
CC:
abarth-chromium, ben+mojo_chromium.org, cbentzel+watch_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Refactor IsolateHolder to be able to always create the isolate Currently, blink creates its own isolates. We want to always use an IsolateHolder to create the isolates. To be able to do this, I introduce an Initialize method that setups V8. The new IsolateHolder ctor now doesn't take any parameters but just creates new isolates according to the configuration. All non-blink gin users are cut over to the new API BUG=none R=abarth@chromium.org,andrewhayden@chromium.org,eroman@chromium.org Committed: https://crrev.com/2f43f2c92879b36d1262d02fba4e32890912b0b5 Cr-Commit-Position: refs/heads/master@{#294262}

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -27 lines) Patch
M gin/array_buffer.h View 1 1 chunk +1 line, -1 line 0 comments Download
M gin/isolate_holder.cc View 1 4 chunks +21 lines, -16 lines 0 comments Download
M gin/public/isolate_holder.h View 1 chunk +7 lines, -1 line 0 comments Download
M gin/shell/gin_main.cc View 2 chunks +4 lines, -1 line 0 comments Download
M gin/shell_runner_unittest.cc View 2 chunks +4 lines, -1 line 0 comments Download
M gin/test/file_runner.cc View 2 chunks +4 lines, -1 line 0 comments Download
M gin/test/v8_test.cc View 2 chunks +4 lines, -1 line 0 comments Download
M mojo/apps/js/main.cc View 2 chunks +4 lines, -1 line 0 comments Download
M mojo/apps/js/test/js_to_cpp_unittest.cc View 2 chunks +4 lines, -1 line 0 comments Download
M net/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_resolver_v8.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
jochen (gone - plz use gerrit)
6 years, 3 months ago (2014-09-09 08:32:17 UTC) #1
Andrew Hayden (chromium.org)
LGTM, but I'm not familiar with the whole background of gin. Read: looks syntactically valid ...
6 years, 3 months ago (2014-09-09 10:08:47 UTC) #2
eroman
net/proxy LGTM
6 years, 3 months ago (2014-09-10 01:40:06 UTC) #3
jochen (gone - plz use gerrit)
Aaron, could you please have a look at //mojo and //gin
6 years, 3 months ago (2014-09-10 09:51:00 UTC) #5
Aaron Boodman
lgtm
6 years, 3 months ago (2014-09-10 22:09:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/553903003/20001
6 years, 3 months ago (2014-09-10 22:15:56 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 11e62ffd667aba41e0cd114760acb532bc62b0cb
6 years, 3 months ago (2014-09-10 23:49:07 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 00:05:20 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2f43f2c92879b36d1262d02fba4e32890912b0b5
Cr-Commit-Position: refs/heads/master@{#294262}

Powered by Google App Engine
This is Rietveld 408576698