Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: gin/test/file_runner.cc

Issue 553903003: Refactor IsolateHolder to be able to always create the isolate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updates Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gin/shell_runner_unittest.cc ('k') | gin/test/v8_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/test/file_runner.cc
diff --git a/gin/test/file_runner.cc b/gin/test/file_runner.cc
index a3872890dc9ec497ba85697332d36131e2e6effd..83228d6d014e5570a63847f149dca2df58941b07 100644
--- a/gin/test/file_runner.cc
+++ b/gin/test/file_runner.cc
@@ -7,6 +7,7 @@
#include "base/files/file_util.h"
#include "base/message_loop/message_loop.h"
#include "base/path_service.h"
+#include "gin/array_buffer.h"
#include "gin/converter.h"
#include "gin/modules/console.h"
#include "gin/modules/module_registry.h"
@@ -57,7 +58,9 @@ void RunTestFromFile(const base::FilePath& path, FileRunnerDelegate* delegate,
base::MessageLoop message_loop;
- gin::IsolateHolder instance(gin::IsolateHolder::kStrictMode);
+ gin::IsolateHolder::Initialize(gin::IsolateHolder::kStrictMode,
+ gin::ArrayBufferAllocator::SharedInstance());
+ gin::IsolateHolder instance;
gin::ShellRunner runner(delegate, instance.isolate());
{
gin::Runner::Scope scope(&runner);
« no previous file with comments | « gin/shell_runner_unittest.cc ('k') | gin/test/v8_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698