Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: gin/test/v8_test.cc

Issue 553903003: Refactor IsolateHolder to be able to always create the isolate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updates Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gin/test/file_runner.cc ('k') | mojo/apps/js/main.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/test/v8_test.cc
diff --git a/gin/test/v8_test.cc b/gin/test/v8_test.cc
index c27154b4f85e237aba5f4c06ff900fd855e41f92..cb6d57374762e0199cb0ac795bed068f3f52d7f5 100644
--- a/gin/test/v8_test.cc
+++ b/gin/test/v8_test.cc
@@ -4,6 +4,7 @@
#include "gin/test/v8_test.h"
+#include "gin/array_buffer.h"
#include "gin/public/isolate_holder.h"
using v8::Context;
@@ -19,7 +20,9 @@ V8Test::~V8Test() {
}
void V8Test::SetUp() {
- instance_.reset(new gin::IsolateHolder(gin::IsolateHolder::kStrictMode));
+ gin::IsolateHolder::Initialize(gin::IsolateHolder::kStrictMode,
+ gin::ArrayBufferAllocator::SharedInstance());
+ instance_.reset(new gin::IsolateHolder);
instance_->isolate()->Enter();
HandleScope handle_scope(instance_->isolate());
context_.Reset(instance_->isolate(), Context::New(instance_->isolate()));
« no previous file with comments | « gin/test/file_runner.cc ('k') | mojo/apps/js/main.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698