Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4157)

Unified Diff: chrome/BUILD.gn

Issue 552843005: Convert GN visibility to be a list. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/gn/functions.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index d49ff3db1e649e68d0fd86d9161c3e835ffa2a86..a23ced1b23310009d010b3be8e786fb1955df33a 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -243,7 +243,7 @@ if (is_win) {
process_version("version_header") {
# TODO(brettW) this should have more reduced visibility, but chrome/browser
# currently depends on this.
- #visibility = ":*"
+ #visibility = [ ":*" ]
source = "version.h.in"
# TODO(brettw) this should move to $target_gen_dir/version.h and
# source files including it should reference it via "chrome/version.h"
@@ -398,7 +398,7 @@ repack("packed_extra_resources") {
# Collects per-locale grit files from many sources into global per-locale files.
chrome_repack_locales("repack_locales_pack") {
- visibility = ":*"
+ visibility = [ ":*" ]
input_locales = locales
@@ -410,7 +410,7 @@ chrome_repack_locales("repack_locales_pack") {
}
chrome_repack_locales("repack_pseudo_locales_pack") {
- visibility = ":*"
+ visibility = [ ":*" ]
input_locales = [ "fake-bidi" ]
@@ -443,7 +443,7 @@ template("chrome_repack_percent") {
copy_name = target_name
repack(repack_name) {
- visibility = ":$copy_name"
+ visibility = [ ":$copy_name" ]
# All sources should also have deps for completeness.
sources = [
"$root_gen_dir/components/resources/component_resources_${percent}_percent.pak",
@@ -486,7 +486,7 @@ template("chrome_repack_percent") {
}
copy(copy_name) {
- visibility = ":*"
+ visibility = [ ":*" ]
deps = [ ":$repack_name" ]
sources = [ repack_output_file ]
outputs = [ "$root_build_dir/chrome_${percent}_percent.pak" ]
« no previous file with comments | « no previous file | tools/gn/functions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698