tools/gn/functions.cc - Issue 552843005: Convert GN visibility to be a list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/functions.cc

Issue 552843005: Convert GN visibility to be a list. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/functions.cc

diff --git a/tools/gn/functions.cc b/tools/gn/functions.cc

index faa7437690eff124487acd73d90a128dba7e0570..f02c7e80a16938a1871fdf81378718d20b1cf0ca 100644

--- a/tools/gn/functions.cc

+++ b/tools/gn/functions.cc

@@ -774,6 +774,8 @@ Value RunFunction(Scope* scope,

Value result = found_function->second.executed_block_runner(

function, args.list_value(), &block_scope, err);

+ if (err->has_error())

+ return Value();

if (!block_scope.CheckForUnusedVars(err))

return Value();

« no previous file with comments | « chrome/BUILD.gn ('k') | tools/gn/variables.cc » ('j') | no next file with comments »