Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Side by Side Diff: chrome/BUILD.gn

Issue 552843005: Convert GN visibility to be a list. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/gn/functions.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/features.gni") 5 import("//build/config/features.gni")
6 import("//build/config/locales.gni") 6 import("//build/config/locales.gni")
7 import("//build/config/ui.gni") 7 import("//build/config/ui.gni")
8 import("//chrome/chrome_repack_locales.gni") 8 import("//chrome/chrome_repack_locales.gni")
9 import("//chrome/version.gni") 9 import("//chrome/version.gni")
10 10
(...skipping 225 matching lines...) Expand 10 before | Expand all | Expand 10 after
236 ] 236 ]
237 } 237 }
238 } 238 }
239 239
240 if (is_win) { 240 if (is_win) {
241 # TODO(brettw) this duplicates "//chrome/common:version" which applies to 241 # TODO(brettw) this duplicates "//chrome/common:version" which applies to
242 # Linux. 242 # Linux.
243 process_version("version_header") { 243 process_version("version_header") {
244 # TODO(brettW) this should have more reduced visibility, but chrome/browser 244 # TODO(brettW) this should have more reduced visibility, but chrome/browser
245 # currently depends on this. 245 # currently depends on this.
246 #visibility = ":*" 246 #visibility = [ ":*" ]
247 source = "version.h.in" 247 source = "version.h.in"
248 # TODO(brettw) this should move to $target_gen_dir/version.h and 248 # TODO(brettw) this should move to $target_gen_dir/version.h and
249 # source files including it should reference it via "chrome/version.h" 249 # source files including it should reference it via "chrome/version.h"
250 output = "$root_gen_dir/version.h" 250 output = "$root_gen_dir/version.h"
251 } 251 }
252 } 252 }
253 253
254 # GYP version: chrome/chrome_resources.gyp:chrome_resources 254 # GYP version: chrome/chrome_resources.gyp:chrome_resources
255 group("resources") { 255 group("resources") {
256 deps = [ 256 deps = [
(...skipping 134 matching lines...) Expand 10 before | Expand all | Expand 10 after
391 # location. 391 # location.
392 if (is_mac || is_ios) { 392 if (is_mac || is_ios) {
393 output = "$root_gen_dir/repack/resources.pak" 393 output = "$root_gen_dir/repack/resources.pak"
394 } else { 394 } else {
395 output = "$root_out_dir/resources.pak" 395 output = "$root_out_dir/resources.pak"
396 } 396 }
397 } 397 }
398 398
399 # Collects per-locale grit files from many sources into global per-locale files. 399 # Collects per-locale grit files from many sources into global per-locale files.
400 chrome_repack_locales("repack_locales_pack") { 400 chrome_repack_locales("repack_locales_pack") {
401 visibility = ":*" 401 visibility = [ ":*" ]
402 402
403 input_locales = locales 403 input_locales = locales
404 404
405 if (is_mac) { 405 if (is_mac) {
406 output_locales = locales_as_mac_outputs 406 output_locales = locales_as_mac_outputs
407 } else { 407 } else {
408 output_locales = locales 408 output_locales = locales
409 } 409 }
410 } 410 }
411 411
412 chrome_repack_locales("repack_pseudo_locales_pack") { 412 chrome_repack_locales("repack_pseudo_locales_pack") {
413 visibility = ":*" 413 visibility = [ ":*" ]
414 414
415 input_locales = [ "fake-bidi" ] 415 input_locales = [ "fake-bidi" ]
416 416
417 if (is_mac) { 417 if (is_mac) {
418 output_locales = [ "fake_bidi" ] # Mac uses underscores. 418 output_locales = [ "fake_bidi" ] # Mac uses underscores.
419 } else { 419 } else {
420 output_locales = [ "fake-bidi" ] 420 output_locales = [ "fake-bidi" ]
421 } 421 }
422 } 422 }
423 423
(...skipping 12 matching lines...) Expand all
436 # String to substitute for the percentage. 436 # String to substitute for the percentage.
437 template("chrome_repack_percent") { 437 template("chrome_repack_percent") {
438 percent = invoker.percent 438 percent = invoker.percent
439 439
440 repack_name = "${target_name}_repack" 440 repack_name = "${target_name}_repack"
441 repack_output_file = "$root_gen_dir/repack/chrome_${percent}_percent.pak" 441 repack_output_file = "$root_gen_dir/repack/chrome_${percent}_percent.pak"
442 442
443 copy_name = target_name 443 copy_name = target_name
444 444
445 repack(repack_name) { 445 repack(repack_name) {
446 visibility = ":$copy_name" 446 visibility = [ ":$copy_name" ]
447 # All sources should also have deps for completeness. 447 # All sources should also have deps for completeness.
448 sources = [ 448 sources = [
449 "$root_gen_dir/components/resources/component_resources_${percent}_percent .pak", 449 "$root_gen_dir/components/resources/component_resources_${percent}_percent .pak",
450 "$root_gen_dir/ui/resources/ui_resources_${percent}_percent.pak", 450 "$root_gen_dir/ui/resources/ui_resources_${percent}_percent.pak",
451 "$root_gen_dir/chrome/renderer_resources_${percent}_percent.pak", 451 "$root_gen_dir/chrome/renderer_resources_${percent}_percent.pak",
452 "$root_gen_dir/chrome/app/theme/theme_resources_${percent}_percent.pak", 452 "$root_gen_dir/chrome/app/theme/theme_resources_${percent}_percent.pak",
453 ] 453 ]
454 454
455 deps = [ 455 deps = [
456 "//chrome/app/theme:theme_resources", 456 "//chrome/app/theme:theme_resources",
(...skipping 22 matching lines...) Expand all
479 sources += [ 479 sources += [
480 "$root_gen_dir/ui/chromeos/resources/ui_chromeos_resources_${percent}_pe rcent.pak", 480 "$root_gen_dir/ui/chromeos/resources/ui_chromeos_resources_${percent}_pe rcent.pak",
481 ] 481 ]
482 deps += [ "//ui/chromeos/resources" ] 482 deps += [ "//ui/chromeos/resources" ]
483 } 483 }
484 484
485 output = repack_output_file 485 output = repack_output_file
486 } 486 }
487 487
488 copy(copy_name) { 488 copy(copy_name) {
489 visibility = ":*" 489 visibility = [ ":*" ]
490 deps = [ ":$repack_name" ] 490 deps = [ ":$repack_name" ]
491 sources = [ repack_output_file ] 491 sources = [ repack_output_file ]
492 outputs = [ "$root_build_dir/chrome_${percent}_percent.pak" ] 492 outputs = [ "$root_build_dir/chrome_${percent}_percent.pak" ]
493 } 493 }
494 } 494 }
495 495
496 chrome_repack_percent("repack_chrome_100_percent") { 496 chrome_repack_percent("repack_chrome_100_percent") {
497 percent = "100" 497 percent = "100"
498 } 498 }
499 499
500 if (enable_hidpi) { 500 if (enable_hidpi) {
501 chrome_repack_percent("repack_chrome_200_percent") { 501 chrome_repack_percent("repack_chrome_200_percent") {
502 percent = "200" 502 percent = "200"
503 } 503 }
504 } 504 }
505 505
506 # GYP version: chrome/chrome_resources.gyp:chrome_strings 506 # GYP version: chrome/chrome_resources.gyp:chrome_strings
507 group("strings") { 507 group("strings") {
508 deps = [ 508 deps = [
509 "//chrome/app:chromium_strings", 509 "//chrome/app:chromium_strings",
510 "//chrome/app:generated_resources", 510 "//chrome/app:generated_resources",
511 "//chrome/app:google_chrome_strings", 511 "//chrome/app:google_chrome_strings",
512 "//chrome/app/resources:locale_settings", 512 "//chrome/app/resources:locale_settings",
513 ] 513 ]
514 } 514 }
OLDNEW
« no previous file with comments | « no previous file | tools/gn/functions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698