Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(989)

Unified Diff: Source/core/loader/appcache/ApplicationCache.h

Issue 552733003: Oilpan: make DOMWindowProperty a GC mixin. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Pacify GC plugin wrt LocalDOMWindow::trace() Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/loader/appcache/ApplicationCache.h
diff --git a/Source/core/loader/appcache/ApplicationCache.h b/Source/core/loader/appcache/ApplicationCache.h
index 75f66106dafb2590fe06ae43b176997569acdc85..7a6809566e0fe770632af37deff5a7ddca6b11f3 100644
--- a/Source/core/loader/appcache/ApplicationCache.h
+++ b/Source/core/loader/appcache/ApplicationCache.h
@@ -49,7 +49,12 @@ public:
{
return adoptRefWillBeNoop(new ApplicationCache(frame));
}
- virtual ~ApplicationCache() { ASSERT(!m_frame); }
+ virtual ~ApplicationCache()
+ {
+#if !ENABLE(OILPAN)
haraken 2014/09/10 02:49:36 I'm OK with this, but the ASSERT(!m_frame) is stil
sof 2014/09/10 05:49:40 It should be.
+ ASSERT(!m_frame);
+#endif
+ }
virtual void willDestroyGlobalObjectInFrame() OVERRIDE;
@@ -74,6 +79,8 @@ public:
static const AtomicString& toEventType(ApplicationCacheHost::EventID);
+ virtual void trace(Visitor*) OVERRIDE;
+
private:
explicit ApplicationCache(LocalFrame*);

Powered by Google App Engine
This is Rietveld 408576698