Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Side by Side Diff: Source/core/loader/appcache/ApplicationCache.h

Issue 552733003: Oilpan: make DOMWindowProperty a GC mixin. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Pacify GC plugin wrt LocalDOMWindow::trace() Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008, 2009 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008, 2009 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 42
43 class ApplicationCache FINAL : public RefCountedWillBeGarbageCollectedFinalized< ApplicationCache>, public EventTargetWithInlineData, public DOMWindowProperty { 43 class ApplicationCache FINAL : public RefCountedWillBeGarbageCollectedFinalized< ApplicationCache>, public EventTargetWithInlineData, public DOMWindowProperty {
44 DEFINE_WRAPPERTYPEINFO(); 44 DEFINE_WRAPPERTYPEINFO();
45 REFCOUNTED_EVENT_TARGET(ApplicationCache); 45 REFCOUNTED_EVENT_TARGET(ApplicationCache);
46 WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(ApplicationCache); 46 WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(ApplicationCache);
47 public: 47 public:
48 static PassRefPtrWillBeRawPtr<ApplicationCache> create(LocalFrame* frame) 48 static PassRefPtrWillBeRawPtr<ApplicationCache> create(LocalFrame* frame)
49 { 49 {
50 return adoptRefWillBeNoop(new ApplicationCache(frame)); 50 return adoptRefWillBeNoop(new ApplicationCache(frame));
51 } 51 }
52 virtual ~ApplicationCache() { ASSERT(!m_frame); } 52 virtual ~ApplicationCache()
53 {
54 #if !ENABLE(OILPAN)
haraken 2014/09/10 02:49:36 I'm OK with this, but the ASSERT(!m_frame) is stil
sof 2014/09/10 05:49:40 It should be.
55 ASSERT(!m_frame);
56 #endif
57 }
53 58
54 virtual void willDestroyGlobalObjectInFrame() OVERRIDE; 59 virtual void willDestroyGlobalObjectInFrame() OVERRIDE;
55 60
56 unsigned short status() const; 61 unsigned short status() const;
57 void update(ExceptionState&); 62 void update(ExceptionState&);
58 void swapCache(ExceptionState&); 63 void swapCache(ExceptionState&);
59 void abort(); 64 void abort();
60 65
61 // Explicitly named attribute event listener helpers 66 // Explicitly named attribute event listener helpers
62 67
63 DEFINE_ATTRIBUTE_EVENT_LISTENER(checking); 68 DEFINE_ATTRIBUTE_EVENT_LISTENER(checking);
64 DEFINE_ATTRIBUTE_EVENT_LISTENER(error); 69 DEFINE_ATTRIBUTE_EVENT_LISTENER(error);
65 DEFINE_ATTRIBUTE_EVENT_LISTENER(noupdate); 70 DEFINE_ATTRIBUTE_EVENT_LISTENER(noupdate);
66 DEFINE_ATTRIBUTE_EVENT_LISTENER(downloading); 71 DEFINE_ATTRIBUTE_EVENT_LISTENER(downloading);
67 DEFINE_ATTRIBUTE_EVENT_LISTENER(progress); 72 DEFINE_ATTRIBUTE_EVENT_LISTENER(progress);
68 DEFINE_ATTRIBUTE_EVENT_LISTENER(updateready); 73 DEFINE_ATTRIBUTE_EVENT_LISTENER(updateready);
69 DEFINE_ATTRIBUTE_EVENT_LISTENER(cached); 74 DEFINE_ATTRIBUTE_EVENT_LISTENER(cached);
70 DEFINE_ATTRIBUTE_EVENT_LISTENER(obsolete); 75 DEFINE_ATTRIBUTE_EVENT_LISTENER(obsolete);
71 76
72 virtual const AtomicString& interfaceName() const OVERRIDE; 77 virtual const AtomicString& interfaceName() const OVERRIDE;
73 virtual ExecutionContext* executionContext() const OVERRIDE; 78 virtual ExecutionContext* executionContext() const OVERRIDE;
74 79
75 static const AtomicString& toEventType(ApplicationCacheHost::EventID); 80 static const AtomicString& toEventType(ApplicationCacheHost::EventID);
76 81
82 virtual void trace(Visitor*) OVERRIDE;
83
77 private: 84 private:
78 explicit ApplicationCache(LocalFrame*); 85 explicit ApplicationCache(LocalFrame*);
79 86
80 ApplicationCacheHost* applicationCacheHost() const; 87 ApplicationCacheHost* applicationCacheHost() const;
81 }; 88 };
82 89
83 } // namespace blink 90 } // namespace blink
84 91
85 #endif // ApplicationCache_h 92 #endif // ApplicationCache_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698