Source/core/frame/LocalDOMWindow.h - Issue 552733003: Oilpan: make DOMWindowProperty a GC mixin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/LocalDOMWindow.h

Issue 552733003: Oilpan: make DOMWindowProperty a GC mixin. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Pacify GC plugin wrt LocalDOMWindow::trace() Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/frame/LocalDOMWindow.h

diff --git a/Source/core/frame/LocalDOMWindow.h b/Source/core/frame/LocalDOMWindow.h

index 955475e2693e62201f363ff20bcd1ccd63782569..78860b523f84f6506069d572ebdbc56d6ad12206 100644

--- a/Source/core/frame/LocalDOMWindow.h

+++ b/Source/core/frame/LocalDOMWindow.h

@@ -343,7 +343,6 @@ private:

virtual void willDetachFrameHost() OVERRIDE;

void clearDocument();

- void resetDOMWindowProperties();

void willDestroyDocumentInFrame();

// FIXME: Oilpan: the need for this internal method will fall

@@ -365,7 +364,7 @@ private:

bool m_hasBeenReset;

#endif

- HashSet<DOMWindowProperty*> m_properties;

+ WillBeHeapHashSet<RawPtrWillBeMember<DOMWindowProperty> > m_properties;

haraken 2014/09/10 02:49:36 Now I understand that this should be strong member

mutable RefPtrWillBeMember<Screen> m_screen;

mutable RefPtrWillBeMember<History> m_history;