Add ONC 'Source' configuration property

Add ONC 'Source' configuration property

This also includes a bit of JS cleanup to use ONC properties directly
where possible.

BUG=279351
R=pneubeck@chromium.org

Committed: https://crrev.com/b4dd54b73384e5ca0af94aefcef95e4521c338ea
Cr-Commit-Position: refs/heads/master@{#294462}

[stevenjb, 2014-09-09 00:49:08]

stevenjb@chromium.org changed reviewers:
+ pneubeck@chromium.org

[stevenjb, 2014-09-09 00:49:08]

Start the review with the spec and onc changes. If you prefer an alternative
please let me know.

[pneubeck (no reviews), 2014-09-09 19:35:32]

a few comments + the comment in the mail.

both source and owner (there might be other) sound acceptable to me.
you might want to ask someone unbiased about what is easier to understand :-)

https://codereview.chromium.org/552113002/diff/40001/chrome/browser/resources...
File chrome/browser/resources/options/chromeos/internet_detail.js (right):

https://codereview.chromium.org/552113002/diff/40001/chrome/browser/resources...
chrome/browser/resources/options/chromeos/internet_detail.js:420: var shared =
source == 'Device';
previously the meaning of shared was 
  source != 'User'

i.e. the shared message was also shown for unconfigured networks?

https://codereview.chromium.org/552113002/diff/40001/chrome/browser/resources...
chrome/browser/resources/options/chromeos/internet_detail.js:1261: security =
undefined;
this is somehow the inverse of the new function :-)

https://codereview.chromium.org/552113002/diff/40001/chrome/browser/resources...
File chrome/browser/resources/options/chromeos/onc_data.js (right):

https://codereview.chromium.org/552113002/diff/40001/chrome/browser/resources...
chrome/browser/resources/options/chromeos/onc_data.js:140: var source =
this.getActiveValue('Source');
we should ensure that the ConfigurationHandler always sends the Source.

https://codereview.chromium.org/552113002/diff/40001/chrome/browser/resources...
chrome/browser/resources/options/chromeos/onc_data.js:146: 
nit: remove empty line

https://codereview.chromium.org/552113002/diff/40001/chrome/browser/resources...
chrome/browser/resources/options/chromeos/onc_data.js:148: * Returns the WiFi
security type where undefined == 'None'.
nit:
" where undefined == 'None'." -> " with default value 'None'

https://codereview.chromium.org/552113002/diff/40001/chrome/browser/resources...
chrome/browser/resources/options/chromeos/onc_data.js:149: * @return {string}
The secuirity type.
typo: secuirity

https://codereview.chromium.org/552113002/diff/40001/chromeos/network/onc/onc...
File chromeos/network/onc/onc_translator_shill_to_onc.cc (right):

https://codereview.chromium.org/552113002/diff/40001/chromeos/network/onc/onc...
chromeos/network/onc/onc_translator_shill_to_onc.cc:420: if
(shill_dictionary_->GetStringWithoutPathExpansion(shill::kProfileProperty,
If we use the same field for 'policy sources', this might be the wrong place.
Instead we might have to set this in the ManagedNetworkConfigurationHandler
directly, maybe a method 'MNCH::TranslateShillServiceToONC'

https://codereview.chromium.org/552113002/diff/40001/components/onc/docs/onc_...
File components/onc/docs/onc_spec.html (right):

https://codereview.chromium.org/552113002/diff/40001/components/onc/docs/onc_...
components/onc/docs/onc_spec.html:440: The source of this network configuration.
If 'None' then this represents
The first sentence is not providing further details. Is there a good/catchy
definition for 'Source'?
Alternatively, 'Owner' might be simpler to grasp?

In any case, we should describe what the effect of each value is.

[stevenjb, 2014-09-10 00:00:55]

https://codereview.chromium.org/552113002/diff/40001/chrome/browser/resources...
File chrome/browser/resources/options/chromeos/internet_detail.js (right):

https://codereview.chromium.org/552113002/diff/40001/chrome/browser/resources...
chrome/browser/resources/options/chromeos/internet_detail.js:420: var shared =
source == 'Device';
On 2014/09/09 19:35:31, pneubeck wrote:
> previously the meaning of shared was 
>   source != 'User'
> 
> i.e. the shared message was also shown for unconfigured networks?

That was deliberate, I think the new logic is better.

https://codereview.chromium.org/552113002/diff/40001/chrome/browser/resources...
chrome/browser/resources/options/chromeos/internet_detail.js:1261: security =
undefined;
On 2014/09/09 19:35:31, pneubeck wrote:
> this is somehow the inverse of the new function :-)

Yes, I know, but I don't like getWiFiSecurity returning undefined, that seems
awkward. The logic for setOrHodeParent hides undefined properties, and we don't
want to show 'Security: None'.

https://codereview.chromium.org/552113002/diff/40001/chrome/browser/resources...
File chrome/browser/resources/options/chromeos/onc_data.js (right):

https://codereview.chromium.org/552113002/diff/40001/chrome/browser/resources...
chrome/browser/resources/options/chromeos/onc_data.js:140: var source =
this.getActiveValue('Source');
On 2014/09/09 19:35:32, pneubeck wrote:
> we should ensure that the ConfigurationHandler always sends the Source.

That seems unnecessarily verbose to me, and would involve changing a lot of test
expectations.

https://codereview.chromium.org/552113002/diff/40001/chrome/browser/resources...
chrome/browser/resources/options/chromeos/onc_data.js:146: 
On 2014/09/09 19:35:31, pneubeck wrote:
> nit: remove empty line

Done.

https://codereview.chromium.org/552113002/diff/40001/chrome/browser/resources...
chrome/browser/resources/options/chromeos/onc_data.js:148: * Returns the WiFi
security type where undefined == 'None'.
On 2014/09/09 19:35:32, pneubeck wrote:
> nit:
> " where undefined == 'None'." -> " with default value 'None'

Done.

https://codereview.chromium.org/552113002/diff/40001/chrome/browser/resources...
chrome/browser/resources/options/chromeos/onc_data.js:149: * @return {string}
The secuirity type.
On 2014/09/09 19:35:32, pneubeck wrote:
> typo: secuirity

Done.

https://codereview.chromium.org/552113002/diff/40001/chromeos/network/onc/onc...
File chromeos/network/onc/onc_translator_shill_to_onc.cc (right):

https://codereview.chromium.org/552113002/diff/40001/chromeos/network/onc/onc...
chromeos/network/onc/onc_translator_shill_to_onc.cc:420: if
(shill_dictionary_->GetStringWithoutPathExpansion(shill::kProfileProperty,
On 2014/09/09 19:35:32, pneubeck wrote:
> If we use the same field for 'policy sources', this might be the wrong place.
> Instead we might have to set this in the ManagedNetworkConfigurationHandler
> directly, maybe a method 'MNCH::TranslateShillServiceToONC'

I think the right thing to do is to pass ONCSource to
TranslateShillServiceToONCPart.

https://codereview.chromium.org/552113002/diff/40001/components/onc/docs/onc_...
File components/onc/docs/onc_spec.html (right):

https://codereview.chromium.org/552113002/diff/40001/components/onc/docs/onc_...
components/onc/docs/onc_spec.html:440: The source of this network configuration.
If 'None' then this represents
On 2014/09/09 19:35:32, pneubeck wrote:
> The first sentence is not providing further details. Is there a good/catchy
> definition for 'Source'?
> Alternatively, 'Owner' might be simpler to grasp?
> 
> In any case, we should describe what the effect of each value is.

I tried to clarify. I thought about it some and I think 'Owner' is itself
confusing, as it may also refer to the device owner. I'm pretty happy with
'Source' but am still open to alternatives.

[stevenjb, 2014-09-10 00:26:02]

https://codereview.chromium.org/552113002/diff/40001/chrome/browser/resources...
File chrome/browser/resources/options/chromeos/onc_data.js (right):

https://codereview.chromium.org/552113002/diff/40001/chrome/browser/resources...
chrome/browser/resources/options/chromeos/onc_data.js:140: var source =
this.getActiveValue('Source');
On 2014/09/10 00:00:55, stevenjb wrote:
> On 2014/09/09 19:35:32, pneubeck wrote:
> > we should ensure that the ConfigurationHandler always sends the Source.
> 
> That seems unnecessarily verbose to me, and would involve changing a lot of
test
> expectations.

Also, in practice, any configuration that actually comes from Shill will have
the Profile property set so 'Source' will also be set, i.e. the code below is
only a convenience to support the fake implementations.

[pneubeck (no reviews), 2014-09-10 10:49:39]

https://codereview.chromium.org/552113002/diff/40001/chrome/browser/resources...
File chrome/browser/resources/options/chromeos/onc_data.js (right):

https://codereview.chromium.org/552113002/diff/40001/chrome/browser/resources...
chrome/browser/resources/options/chromeos/onc_data.js:140: var source =
this.getActiveValue('Source');
Ah, I didn't mean to remove this fallback handling here.

Instead, I just meant that Source should always be send.
For != None, this is obviously a requirement.
For 'None' this is arguable, you're right. We could also not send the default
value 'None' as we do for some other properties.

On 2014/09/10 00:26:01, stevenjb wrote:
> On 2014/09/10 00:00:55, stevenjb wrote:
> > On 2014/09/09 19:35:32, pneubeck wrote:
> > > we should ensure that the ConfigurationHandler always sends the Source.
> > 
> > That seems unnecessarily verbose to me, and would involve changing a lot of
> test
> > expectations.
> 
> Also, in practice, any configuration that actually comes from Shill will have
> the Profile property set so 'Source' will also be set, i.e. the code below is
> only a convenience to support the fake implementations.

https://codereview.chromium.org/552113002/diff/60001/chromeos/network/managed...
File chromeos/network/managed_network_configuration_handler_impl.cc (right):

https://codereview.chromium.org/552113002/diff/60001/chromeos/network/managed...
chromeos/network/managed_network_configuration_handler_impl.cc:221:
*shill_properties, ::onc::ONC_SOURCE_NONE,
See next comment. This leads to incorrect 'Source' values.

https://codereview.chromium.org/552113002/diff/60001/chromeos/network/network...
File chromeos/network/network_util.cc (right):

https://codereview.chromium.org/552113002/diff/60001/chromeos/network/network...
chromeos/network/network_util.cc:151: ::onc::ONC_SOURCE_NONE,
Ohoh, note that this will lead to incorrect 'Source' values!

The way you implemented it, the onc_source argument is mandatory. Either we
change the implementation to make the argument optional, i.e. if it's not
provided the 'Source' property will not be added.
Or, the argument must always be correctly provided.

https://codereview.chromium.org/552113002/diff/60001/chromeos/network/onc/onc...
File chromeos/network/onc/onc_translator.h (right):

https://codereview.chromium.org/552113002/diff/60001/chromeos/network/onc/onc...
chromeos/network/onc/onc_translator.h:40: // by the UI. If |onc_source|
specifies a Device or User policy then the
As mentioned in the other comment, this leads to the misuse of providing
'ONC_SOURCE_NONE' as default value if the caller doesn't know the source, which
is not correct.

1) We could keep it as is, then we have to ensure that the argument is always
correctly provided.

2) Make two separate functions, one with and the other without the onc_source
argument, which will not output a 'Source' property.

3) We could update the ONCSource enum to (which could also be renamed to
NetworkPolicySource):
  { UNKNOWN, NONE, USER_POLICY, DEVICE_POLICY }
  (note that the USER_IMPORT is missing, which is anyways deprecated IMO)

   If the argument onc_source equals UNKNOWN, then no 'Source' property is
output.

https://codereview.chromium.org/552113002/diff/60001/chromeos/network/onc/onc...
File chromeos/network/onc/onc_translator_shill_to_onc.cc (right):

https://codereview.chromium.org/552113002/diff/60001/chromeos/network/onc/onc...
chromeos/network/onc/onc_translator_shill_to_onc.cc:437: else
please add a comment that ONC_SOURCE_USER_IMPORT (which should actually be
removed, IMO), is handled the same as ONC_SOURCE_NONE.
Which I agree that it should.

https://codereview.chromium.org/552113002/diff/60001/components/onc/docs/onc_...
File components/onc/docs/onc_spec.html (right):

https://codereview.chromium.org/552113002/diff/60001/components/onc/docs/onc_...
components/onc/docs/onc_spec.html:440: Indicates whether the network was
configured for the user or the device
'was' -> 'is' ?

'configured _for_ the user' seems not right, the user policy also configures the
network _for_ the user.
How about:

"Indicates whether the network was configured by a policy (UserPolicy or
DevicePolicy) or by a user (User or Device).
If the user shared the configuration with all users of this device (device like
PC or Laptop), Source will be set to 'Device'.
If this network is a visible (e.g. a visible WiFi network) but not configured,
Source is set to 'None'.
"

I guess you don't want to over-specify, but we should at least give a hint of
the effect of this value, like 'who can modify', 'who can see or connect the
config'...

https://codereview.chromium.org/552113002/diff/60001/components/onc/docs/onc_...
components/onc/docs/onc_spec.html:441: and whether or not it was configured by a
policy. If 'None' then this
nit: 'None' -> <span class="value">None</span>

https://codereview.chromium.org/552113002/diff/60001/components/onc/docs/onc_...
components/onc/docs/onc_spec.html:441: and whether or not it was configured by a
policy. If 'None' then this
'was' -> 'is' ?

[stevenjb, 2014-09-10 17:32:16]

ptal

https://codereview.chromium.org/552113002/diff/60001/chromeos/network/managed...
File chromeos/network/managed_network_configuration_handler_impl.cc (right):

https://codereview.chromium.org/552113002/diff/60001/chromeos/network/managed...
chromeos/network/managed_network_configuration_handler_impl.cc:221:
*shill_properties, ::onc::ONC_SOURCE_NONE,
On 2014/09/10 10:49:38, pneubeck wrote:
> See next comment. This leads to incorrect 'Source' values.

Acknowledged.

https://codereview.chromium.org/552113002/diff/60001/chromeos/network/network...
File chromeos/network/network_util.cc (right):

https://codereview.chromium.org/552113002/diff/60001/chromeos/network/network...
chromeos/network/network_util.cc:151: ::onc::ONC_SOURCE_NONE,
On 2014/09/10 10:49:38, pneubeck wrote:
> Ohoh, note that this will lead to incorrect 'Source' values!
> 
> The way you implemented it, the onc_source argument is mandatory. Either we
> change the implementation to make the argument optional, i.e. if it's not
> provided the 'Source' property will not be added.
> Or, the argument must always be correctly provided.

I guess I was assuming that we wouldn't care in the places we always passed in
None, but you are right, it would be better to explicitly pass 'unknown. I think
it is more clear to add UNKNOWN as an enum entry than doing something like
passing a pointer that could be NULL.

https://codereview.chromium.org/552113002/diff/60001/chromeos/network/onc/onc...
File chromeos/network/onc/onc_translator.h (right):

https://codereview.chromium.org/552113002/diff/60001/chromeos/network/onc/onc...
chromeos/network/onc/onc_translator.h:40: // by the UI. If |onc_source|
specifies a Device or User policy then the
On 2014/09/10 10:49:38, pneubeck wrote:
> As mentioned in the other comment, this leads to the misuse of providing
> 'ONC_SOURCE_NONE' as default value if the caller doesn't know the source,
which
> is not correct.
> 
> 1) We could keep it as is, then we have to ensure that the argument is always
> correctly provided.
> 
> 2) Make two separate functions, one with and the other without the onc_source
> argument, which will not output a 'Source' property.
> 
> 3) We could update the ONCSource enum to (which could also be renamed to
> NetworkPolicySource):
>   { UNKNOWN, NONE, USER_POLICY, DEVICE_POLICY }
>   (note that the USER_IMPORT is missing, which is anyways deprecated IMO)
> 
>    If the argument onc_source equals UNKNOWN, then no 'Source' property is
> output.
Heh, I already jumped to '3' :)

https://codereview.chromium.org/552113002/diff/60001/chromeos/network/onc/onc...
File chromeos/network/onc/onc_translator_shill_to_onc.cc (right):

https://codereview.chromium.org/552113002/diff/60001/chromeos/network/onc/onc...
chromeos/network/onc/onc_translator_shill_to_onc.cc:437: else
On 2014/09/10 10:49:38, pneubeck wrote:
> please add a comment that ONC_SOURCE_USER_IMPORT (which should actually be
> removed, IMO), is handled the same as ONC_SOURCE_NONE.
> Which I agree that it should.

Yeah, I have no clue what USER_IMPORT is even for. I will add a comment in the
header.

https://codereview.chromium.org/552113002/diff/60001/components/onc/docs/onc_...
File components/onc/docs/onc_spec.html (right):

https://codereview.chromium.org/552113002/diff/60001/components/onc/docs/onc_...
components/onc/docs/onc_spec.html:440: Indicates whether the network was
configured for the user or the device
On 2014/09/10 10:49:38, pneubeck wrote:
> 'was' -> 'is' ?
> 
> 'configured _for_ the user' seems not right, the user policy also configures
the
> network _for_ the user.
> How about:
> 
> "Indicates whether the network was configured by a policy (UserPolicy or
> DevicePolicy) or by a user (User or Device).
> If the user shared the configuration with all users of this device (device
like
> PC or Laptop), Source will be set to 'Device'.
> If this network is a visible (e.g. a visible WiFi network) but not configured,
> Source is set to 'None'.
> "
> 
> I guess you don't want to over-specify, but we should at least give a hint of
> the effect of this value, like 'who can modify', 'who can see or connect the
> config'...

I tried presenting this as a list of allowed values and what they mean, lmkwyt.

https://codereview.chromium.org/552113002/diff/60001/components/onc/docs/onc_...
components/onc/docs/onc_spec.html:441: and whether or not it was configured by a
policy. If 'None' then this
On 2014/09/10 10:49:38, pneubeck wrote:
> nit: 'None' -> <span class="value">None</span>

Acknowledged.

https://codereview.chromium.org/552113002/diff/60001/components/onc/docs/onc_...
components/onc/docs/onc_spec.html:441: and whether or not it was configured by a
policy. If 'None' then this
On 2014/09/10 10:49:38, pneubeck wrote:
> 'was' -> 'is' ?

Acknowledged.

[pneubeck (no reviews), 2014-09-10 20:22:39]

lgtm with a few remaining comments.

https://codereview.chromium.org/552113002/diff/60001/chromeos/network/onc/onc...
File chromeos/network/onc/onc_translator_shill_to_onc.cc (right):

https://codereview.chromium.org/552113002/diff/60001/chromeos/network/onc/onc...
chromeos/network/onc/onc_translator_shill_to_onc.cc:437: else
On 2014/09/10 17:32:15, stevenjb wrote:
> On 2014/09/10 10:49:38, pneubeck wrote:
> > please add a comment that ONC_SOURCE_USER_IMPORT (which should actually be
> > removed, IMO), is handled the same as ONC_SOURCE_NONE.
> > Which I agree that it should.
> 
> Yeah, I have no clue what USER_IMPORT is even for. I will add a comment in the
> header.

USER_IMPORT is set if a user imports an ONC file from net-internals/#chromeos .
Many releases ago (at the ages of NetworkLibrary) that had a similar effect as
policy.
But it should really be _exactly_ the same as if the user had used the UI. Thus
this source is just not be used...

https://codereview.chromium.org/552113002/diff/80001/chromeos/network/policy_...
File chromeos/network/policy_applicator.cc (right):

https://codereview.chromium.org/552113002/diff/80001/chromeos/network/policy_...
chromeos/network/policy_applicator.cc:120: entry_properties, onc_source,
&onc::kNetworkWithStateSignature));
you could always pass ONC_SOURCE_UNKNOWN as 'Source' of the result is not used.

https://codereview.chromium.org/552113002/diff/80001/components/onc/docs/onc_...
File components/onc/docs/onc_spec.html (right):

https://codereview.chromium.org/552113002/diff/80001/components/onc/docs/onc_...
components/onc/docs/onc_spec.html:444: <li><span class="value">Device</span>:
Configured for the device.</li>
'device' has many meanings. Please mention 'other users' or clarify 'device'.

This still does not address the fact that your description for 'User' overlaps
with 'UserPolicy'.
Maybe say 'Configured _by_ the active user.' and 'Configured and shared with all
users of this device.'

https://codereview.chromium.org/552113002/diff/80001/components/onc/docs/onc_...
components/onc/docs/onc_spec.html:445: <li><span
class="value">UserPolicy</span>: Configured by a user
drop the 'a' in front of user policy

https://codereview.chromium.org/552113002/diff/80001/components/onc/docs/onc_...
components/onc/docs/onc_spec.html:446: policty for the active user.</li>
typo: policty

https://codereview.chromium.org/552113002/diff/80001/components/onc/docs/onc_...
components/onc/docs/onc_spec.html:447: <li><span
class="value">DevicePolicy</span>: Configured by a device
drop the 'a' in front of device policy

https://codereview.chromium.org/552113002/diff/80001/components/onc/docs/onc_...
components/onc/docs/onc_spec.html:448: policty for the device.</li>
typo: policty

https://codereview.chromium.org/552113002/diff/80001/components/onc/docs/onc_...
components/onc/docs/onc_spec.html:449: <li><span class="value">None</span>: Not
configured, e.g. a visibe
typo: visibe

[stevenjb, 2014-09-10 22:42:02]

https://codereview.chromium.org/552113002/diff/80001/chromeos/network/policy_...
File chromeos/network/policy_applicator.cc (right):

https://codereview.chromium.org/552113002/diff/80001/chromeos/network/policy_...
chromeos/network/policy_applicator.cc:120: entry_properties, onc_source,
&onc::kNetworkWithStateSignature));
On 2014/09/10 20:22:38, pneubeck wrote:
> you could always pass ONC_SOURCE_UNKNOWN as 'Source' of the result is not
used.

Done.

https://codereview.chromium.org/552113002/diff/80001/components/onc/docs/onc_...
File components/onc/docs/onc_spec.html (right):

https://codereview.chromium.org/552113002/diff/80001/components/onc/docs/onc_...
components/onc/docs/onc_spec.html:444: <li><span class="value">Device</span>:
Configured for the device.</li>
On 2014/09/10 20:22:38, pneubeck wrote:
> 'device' has many meanings. Please mention 'other users' or clarify 'device'.
> 
> This still does not address the fact that your description for 'User' overlaps
> with 'UserPolicy'.
> Maybe say 'Configured _by_ the active user.' and 'Configured and shared with
all
> users of this device.'

Done.

https://codereview.chromium.org/552113002/diff/80001/components/onc/docs/onc_...
components/onc/docs/onc_spec.html:445: <li><span
class="value">UserPolicy</span>: Configured by a user
On 2014/09/10 20:22:39, pneubeck wrote:
> drop the 'a' in front of user policy
That's awkward in english, but s/a/the/.

https://codereview.chromium.org/552113002/diff/80001/components/onc/docs/onc_...
components/onc/docs/onc_spec.html:446: policty for the active user.</li>
On 2014/09/10 20:22:39, pneubeck wrote:
> typo: policty

Done.

https://codereview.chromium.org/552113002/diff/80001/components/onc/docs/onc_...
components/onc/docs/onc_spec.html:447: <li><span
class="value">DevicePolicy</span>: Configured by a device
On 2014/09/10 20:22:38, pneubeck wrote:
> drop the 'a' in front of device policy

Done.

https://codereview.chromium.org/552113002/diff/80001/components/onc/docs/onc_...
components/onc/docs/onc_spec.html:448: policty for the device.</li>
On 2014/09/10 20:22:39, pneubeck wrote:
> typo: policty

Done.

https://codereview.chromium.org/552113002/diff/80001/components/onc/docs/onc_...
components/onc/docs/onc_spec.html:449: <li><span class="value">None</span>: Not
configured, e.g. a visibe
On 2014/09/10 20:22:39, pneubeck wrote:
> typo: visibe

Done.

[stevenjb, 2014-09-10 22:42:07]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2014-09-10 22:51:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/552113002/100001

[commit-bot: I haz the power, 2014-09-11 01:05:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-11 01:05:27]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[stevenjb, 2014-09-11 01:13:47]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2014-09-11 01:16:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/552113002/120001

[commit-bot: I haz the power, 2014-09-11 02:31:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-11 02:31:10]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[pneubeck (no reviews), 2014-09-11 07:07:42]

thanks

[stevenjb, 2014-09-11 16:25:37]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2014-09-11 16:26:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/552113002/140001

[commit-bot: I haz the power, 2014-09-11 18:18:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-11 18:18:32]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[stevenjb, 2014-09-11 20:56:25]

Committed patchset #10 (id:180001) to pending queue manually as d3ea712
(presubmit successful).

[commit-bot: I haz the power, 2014-09-11 21:03:24]

Patchset 10 (id:??) landed as
https://crrev.com/b4dd54b73384e5ca0af94aefcef95e4521c338ea
Cr-Commit-Position: refs/heads/master@{#294462}