components/onc/docs/onc_spec.html - Issue 552113002: Add ONC 'Source' configuration property

Side by Side Diff: components/onc/docs/onc_spec.html

Issue 552113002: Add ONC 'Source' configuration property (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_279351_internet_options_9a

Patch Set: Rebase, Feedback, add *Policy sources Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chromeos/network/onc/onc_translator_shill_to_onc.cc ('K') | « chromeos/test/data/network/translation_of_shill_wifi_with_state.onc ('k') | components/onc/onc_constants.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <meta charset="utf-8">	4 <meta charset="utf-8">

5 <link rel="stylesheet" href="onc_spec.css" >	5 <link rel="stylesheet" href="onc_spec.css" >

6 <script src="onc_spec.js"></script>	6 <script src="onc_spec.js"></script>

7 <title>Open Network Configuration Format</title>	7 <title>Open Network Configuration Format</title>

8 </head>	8 </head>

9 <body>	9 <body>

10	10

(...skipping 413 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
424 <dt class="field">MacAddress</dt>	424 <dt class="field">MacAddress</dt>

425 <dd>	425 <dd>

426 <span class="field_meta">	426 <span class="field_meta">

427 (optional, read-only)	427 (optional, read-only)

428 <span class="type">string</span>	428 <span class="type">string</span>

429 </span>	429 </span>

430 The MAC address for the network. Only applies to connected non-virtual	430 The MAC address for the network. Only applies to connected non-virtual

431 networks. The format is 00:11:22:AA:BB:CC.	431 networks. The format is 00:11:22:AA:BB:CC.

432 </dd>	432 </dd>

433	433

	434 <dt class="field">Source</dt>

	435 <dd>

	436 <span class="field_meta">

	437 (optional, read-only)

	438 <span class="type">string</span>

	439 </span>

	440 Indicates whether the network was configured for the user or the device
	pneubeck (no reviews) 2014/09/10 10:49:38 'was' -> 'is' ? 'configured _for_ the user' seems 'was' -> 'is' ? 'configured _for_ the user' seems not right, the user policy also configures the network _for_ the user. How about: "Indicates whether the network was configured by a policy (UserPolicy or DevicePolicy) or by a user (User or Device). If the user shared the configuration with all users of this device (device like PC or Laptop), Source will be set to 'Device'. If this network is a visible (e.g. a visible WiFi network) but not configured, Source is set to 'None'. " I guess you don't want to over-specify, but we should at least give a hint of the effect of this value, like 'who can modify', 'who can see or connect the config'... stevenjb 2014/09/10 17:32:15 I tried presenting this as a list of allowed value Show quoted text On 2014/09/10 10:49:38, pneubeck wrote: > 'was' -> 'is' ? > > 'configured _for_ the user' seems not right, the user policy also configures the > network _for_ the user. > How about: > > "Indicates whether the network was configured by a policy (UserPolicy or > DevicePolicy) or by a user (User or Device). > If the user shared the configuration with all users of this device (device like > PC or Laptop), Source will be set to 'Device'. > If this network is a visible (e.g. a visible WiFi network) but not configured, > Source is set to 'None'. > " > > I guess you don't want to over-specify, but we should at least give a hint of > the effect of this value, like 'who can modify', 'who can see or connect the > config'... I tried presenting this as a list of allowed values and what they mean, lmkwyt.
	441 and whether or not it was configured by a policy. If 'None' then this
	pneubeck (no reviews) 2014/09/10 10:49:38 'was' -> 'is' ? 'was' -> 'is' ? pneubeck (no reviews) 2014/09/10 10:49:38 nit: 'None' -> <span class="value">None</span> nit: 'None' -> <span class="value">None</span> stevenjb 2014/09/10 17:32:15 Acknowledged. Show quoted text On 2014/09/10 10:49:38, pneubeck wrote: > nit: 'None' -> <span class="value">None</span> Acknowledged. stevenjb 2014/09/10 17:32:16 Acknowledged. Show quoted text On 2014/09/10 10:49:38, pneubeck wrote: > 'was' -> 'is' ? Acknowledged.
	442 represents a visible but unconfigured network.

	443 <span class="rule">

	444 <span class="rule_id"></span>

	445 Allowed values are:

	446 <span class="value">User</span>,

	447 <span class="value">Device</span>,

	448 <span class="value">UserPolicy</span>,

	449 <span class="value">DevicePolicy</span>,

	450 <span class="value">None</span>

	451 </span>

	452 </dd>

	453

434 <dt class="field">Priority</dt>	454 <dt class="field">Priority</dt>

435 <dd>	455 <dd>

436 <span class="field_meta">	456 <span class="field_meta">

437 (optional)	457 (optional)

438 <span class="type">integer</span>	458 <span class="type">integer</span>

439 </span>	459 </span>

440 Provides a suggested priority value for this network. May be used by the	460 Provides a suggested priority value for this network. May be used by the

441 system to determine which network to connect to when multiple configured	461 system to determine which network to connect to when multiple configured

442 networks are available (or may be ignored).	462 networks are available (or may be ignored).

443 </dd>	463 </dd>

(...skipping 1919 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
2363 is transmitted or saved to disk should be secure. On client device, when	2383 is transmitted or saved to disk should be secure. On client device, when

2364 user names for connections that are user-specific are persisted to disk,	2384 user names for connections that are user-specific are persisted to disk,

2365 they should be stored in a location that is encrypted. Users can also opt in	2385 they should be stored in a location that is encrypted. Users can also opt in

2366 these cases to not save their user credentials in the config file and will	2386 these cases to not save their user credentials in the config file and will

2367 instead be prompted when they are needed.	2387 instead be prompted when they are needed.

2368 </p>	2388 </p>

2369 </section>	2389 </section>

2370 </section>	2390 </section>

2371 </body>	2391 </body>

2372 </html>	2392 </html>

OLD	NEW