Add ONC 'Source' configuration property

chromeos/network/network_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/network/network_util.h"
 
 #include "base/strings/string_tokenizer.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "chromeos/network/network_state.h"
@@ skipping 129 matching lines @@
   return true;
 }
 
 scoped_ptr<base::DictionaryValue> TranslateNetworkStateToONC(
     const NetworkState* network) {
   // Get the properties from the NetworkState.
   base::DictionaryValue shill_dictionary;
   network->GetStateProperties(&shill_dictionary);
 
   scoped_ptr<base::DictionaryValue> onc_dictionary =
-      TranslateShillServiceToONCPart(
-          shill_dictionary, &onc::kNetworkWithStateSignature);
+      TranslateShillServiceToONCPart(shill_dictionary,
+                                     ::onc::ONC_SOURCE_NONE,

[pneubeck (no reviews), 2014/09/10 10:49:38]

Ohoh, note that this will lead to incorrect 'Source' values!

The way you implemented it, the onc_source argument is mandatory. Either we
change the implementation to make the argument optional, i.e. if it's not
provided the 'Source' property will not be added.
Or, the argument must always be correctly provided.

[stevenjb, 2014/09/10 17:32:15]

I guess I was assuming that we wouldn't care in the places we always passed in
None, but you are right, it would be better to explicitly pass 'unknown. I think
it is more clear to add UNKNOWN as an enum entry than doing something like
passing a pointer that could be NULL.

+                                     &onc::kNetworkWithStateSignature);
   return onc_dictionary.Pass();
 }
 
 scoped_ptr<base::ListValue> TranslateNetworkListToONC(
     NetworkTypePattern pattern,
     bool configured_only,
     bool visible_only,
     int limit,
     bool debugging_properties) {
   NetworkStateHandler::NetworkStateList network_states;
@@ skipping 23 matching lines @@
 std::string TranslateONCTypeToShill(const std::string& onc_type) {
   if (onc_type == ::onc::network_type::kEthernet)
     return shill::kTypeEthernet;
   std::string shill_type;
   onc::TranslateStringToShill(onc::kNetworkTypeTable, onc_type, &shill_type);
   return shill_type;
 }
 
 }  // namespace network_util
 }  // namespace chromeos