tools/telemetry/telemetry/results/chart_json_output_formatter_unittest.py - Issue 551973002: [Telemetry] Make --chartjson output chart.json instead of to stdout.

Unified Diff: tools/telemetry/telemetry/results/chart_json_output_formatter_unittest.py

Issue 551973002: [Telemetry] Make --chartjson output chart.json instead of to stdout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Ned's comments Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/results/chart_json_output_formatter.py ('k') | tools/telemetry/telemetry/results/chart_json_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/results/chart_json_output_formatter_unittest.py

diff --git a/tools/telemetry/telemetry/results/chart_json_unittest.py b/tools/telemetry/telemetry/results/chart_json_output_formatter_unittest.py

similarity index 84%

rename from tools/telemetry/telemetry/results/chart_json_unittest.py

rename to tools/telemetry/telemetry/results/chart_json_output_formatter_unittest.py

index be32b387966ac07989d315983a517d078c4c2c7d..6ceacbca0bbb18399d3c985f318d8dc154ed4176 100644

--- a/tools/telemetry/telemetry/results/chart_json_unittest.py

+++ b/tools/telemetry/telemetry/results/chart_json_output_formatter_unittest.py

@@ -7,7 +7,7 @@ import unittest

import json

from telemetry import benchmark

-from telemetry.results import chart_json

+from telemetry.results import chart_json_output_formatter

from telemetry.page import page_set

from telemetry.value import scalar

from telemetry.value import list_of_scalar_values

@@ -29,7 +29,7 @@ class ChartJsonTest(unittest.TestCase):

page_specific_values = [v0]

summary_values = []

- d = chart_json.ResultsAsChartDict(

+ d = chart_json_output_formatter._ResultsAsChartDict( # pylint: disable=W0212

self._benchmark_metadata,

page_specific_values,

summary_values)

@@ -39,7 +39,7 @@ class ChartJsonTest(unittest.TestCase):

page_specific_values = []

summary_values = []

- d = chart_json.ResultsAsChartDict(

+ d = chart_json_output_formatter._ResultsAsChartDict( # pylint: disable=W0212

self._benchmark_metadata,

page_specific_values,

summary_values)

@@ -53,7 +53,7 @@ class ChartJsonTest(unittest.TestCase):

page_specific_values = [v0, v1]

summary_values = []

- d = chart_json.ResultsAsChartDict(

+ d = chart_json_output_formatter._ResultsAsChartDict( # pylint: disable=W0212

self._benchmark_metadata,

page_specific_values,

summary_values)

@@ -67,7 +67,7 @@ class ChartJsonTest(unittest.TestCase):

page_specific_values = [v0, v1]

summary_values = []

- d = chart_json.ResultsAsChartDict(

+ d = chart_json_output_formatter._ResultsAsChartDict( # pylint: disable=W0212

self._benchmark_metadata,

page_specific_values,

summary_values)

@@ -83,7 +83,7 @@ class ChartJsonTest(unittest.TestCase):

page_specific_values = []

summary_values = [v0]

- d = chart_json.ResultsAsChartDict(

+ d = chart_json_output_formatter._ResultsAsChartDict( # pylint: disable=W0212

self._benchmark_metadata,

page_specific_values,

summary_values)

@@ -96,7 +96,7 @@ class ChartJsonTest(unittest.TestCase):

page_specific_values = []

summary_values = [v0]

- d = chart_json.ResultsAsChartDict(

+ d = chart_json_output_formatter._ResultsAsChartDict( # pylint: disable=W0212

self._benchmark_metadata,

page_specific_values,

summary_values)

@@ -109,7 +109,7 @@ class ChartJsonTest(unittest.TestCase):

page_specific_values = []

summary_values = [v0]

- d = chart_json.ResultsAsChartDict(

+ d = chart_json_output_formatter._ResultsAsChartDict( # pylint: disable=W0212

self._benchmark_metadata,

page_specific_values,

summary_values)