Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: tools/telemetry/telemetry/results/chart_json_output_formatter.py

Issue 551973002: [Telemetry] Make --chartjson output chart.json instead of to stdout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Ned's comments Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/results/chart_json_output_formatter.py
diff --git a/tools/telemetry/telemetry/results/chart_json.py b/tools/telemetry/telemetry/results/chart_json_output_formatter.py
similarity index 72%
rename from tools/telemetry/telemetry/results/chart_json.py
rename to tools/telemetry/telemetry/results/chart_json_output_formatter.py
index 68711ad8ac36d244fad278df832d37d45f19b867..3b262c8df288161298c8e7d55ac1dedfb0e9aa4f 100644
--- a/tools/telemetry/telemetry/results/chart_json.py
+++ b/tools/telemetry/telemetry/results/chart_json_output_formatter.py
@@ -4,10 +4,12 @@
import collections
import itertools
+import json
+from telemetry.results import output_formatter
from telemetry.value import summary as summary_module
-def ResultsAsChartDict(benchmark_metadata, page_specific_values,
+def _ResultsAsChartDict(benchmark_metadata, page_specific_values,
summary_values):
"""Produces a dict for serialization to Chart JSON format from raw values.
@@ -55,3 +57,17 @@ def ResultsAsChartDict(benchmark_metadata, page_specific_values,
}
return result_dict
+
+# TODO(eakuefner): Transition this to translate Telemetry JSON.
+class ChartJsonOutputFormatter(output_formatter.OutputFormatter):
+ def __init__(self, output_stream, benchmark_metadata):
+ super(ChartJsonOutputFormatter, self).__init__(output_stream)
+ self._benchmark_metadata = benchmark_metadata
+
+ def Format(self, page_test_results):
+ json.dump(self._ResultsAsChartDict(
+ self._benchmark_metadata,
+ page_test_results.all_page_specific_values,
+ page_test_results.all_summary_values),
+ self.output_stream)
+ self.output_stream.write('\n')

Powered by Google App Engine
This is Rietveld 408576698