Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: tools/telemetry/telemetry/results/chart_json_unittest.py

Issue 551973002: [Telemetry] Make --chartjson output chart.json instead of to stdout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Ned's comments Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/results/chart_json_unittest.py
diff --git a/tools/telemetry/telemetry/results/chart_json_unittest.py b/tools/telemetry/telemetry/results/chart_json_unittest.py
deleted file mode 100644
index be32b387966ac07989d315983a517d078c4c2c7d..0000000000000000000000000000000000000000
--- a/tools/telemetry/telemetry/results/chart_json_unittest.py
+++ /dev/null
@@ -1,117 +0,0 @@
-# Copyright 2014 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-
-import os
-import unittest
-import json
-
-from telemetry import benchmark
-from telemetry.results import chart_json
-from telemetry.page import page_set
-from telemetry.value import scalar
-from telemetry.value import list_of_scalar_values
-
-
-def _MakePageSet():
- ps = page_set.PageSet(file_path=os.path.dirname(__file__))
- ps.AddPageWithDefaultRunNavigate('http://www.foo.com/')
- ps.AddPageWithDefaultRunNavigate('http://www.bar.com/')
- return ps
-
-class ChartJsonTest(unittest.TestCase):
- def setUp(self):
- self._page_set = _MakePageSet()
- self._benchmark_metadata = benchmark.BenchmarkMetadata('benchmark_name')
-
- def testAsChartDictSerializable(self):
- v0 = scalar.ScalarValue(self._page_set[0], 'foo', 'seconds', 3)
- page_specific_values = [v0]
- summary_values = []
-
- d = chart_json.ResultsAsChartDict(
- self._benchmark_metadata,
- page_specific_values,
- summary_values)
- json.dumps(d)
-
- def testAsChartDictBaseKeys(self):
- page_specific_values = []
- summary_values = []
-
- d = chart_json.ResultsAsChartDict(
- self._benchmark_metadata,
- page_specific_values,
- summary_values)
-
- self.assertEquals(d['format_version'], '0.1')
- self.assertEquals(d['benchmark_name'], 'benchmark_name')
-
- def testAsChartDictPageSpecificValuesSamePage(self):
- v0 = scalar.ScalarValue(self._page_set[0], 'foo', 'seconds', 3)
- v1 = scalar.ScalarValue(self._page_set[0], 'foo', 'seconds', 4)
- page_specific_values = [v0, v1]
- summary_values = []
-
- d = chart_json.ResultsAsChartDict(
- self._benchmark_metadata,
- page_specific_values,
- summary_values)
-
- self.assertTrue('foo' in d['charts'])
- self.assertTrue('http://www.foo.com/' in d['charts']['foo'])
-
- def testAsChartDictPageSpecificValuesAndComputedSummary(self):
- v0 = scalar.ScalarValue(self._page_set[0], 'foo', 'seconds', 3)
- v1 = scalar.ScalarValue(self._page_set[1], 'foo', 'seconds', 4)
- page_specific_values = [v0, v1]
- summary_values = []
-
- d = chart_json.ResultsAsChartDict(
- self._benchmark_metadata,
- page_specific_values,
- summary_values)
-
- self.assertTrue('foo' in d['charts'])
- self.assertTrue('http://www.foo.com/' in d['charts']['foo'])
- self.assertTrue('http://www.bar.com/' in d['charts']['foo'])
- self.assertTrue('summary' in d['charts']['foo'])
-
- def testAsChartDictSummaryValueWithTraceName(self):
- v0 = list_of_scalar_values.ListOfScalarValues(None, 'foo.bar', 'seconds',
- [3, 4])
- page_specific_values = []
- summary_values = [v0]
-
- d = chart_json.ResultsAsChartDict(
- self._benchmark_metadata,
- page_specific_values,
- summary_values)
-
- self.assertTrue('bar' in d['charts']['foo'])
-
- def testAsChartDictSummaryValueWithoutTraceName(self):
- v0 = list_of_scalar_values.ListOfScalarValues(None, 'foo', 'seconds',
- [3, 4])
- page_specific_values = []
- summary_values = [v0]
-
- d = chart_json.ResultsAsChartDict(
- self._benchmark_metadata,
- page_specific_values,
- summary_values)
-
- self.assertTrue('summary' in d['charts']['foo'])
-
- def testAsChartDictValueSmokeTest(self):
- v0 = list_of_scalar_values.ListOfScalarValues(None, 'foo.bar', 'seconds',
- [3, 4])
- page_specific_values = []
- summary_values = [v0]
-
- d = chart_json.ResultsAsChartDict(
- self._benchmark_metadata,
- page_specific_values,
- summary_values)
-
- self.assertEquals(d['charts']['foo']['bar']['values'], [3, 4])

Powered by Google App Engine
This is Rietveld 408576698