Source/core/rendering/RenderMultiColumnFlowThread.h - Issue 551263005: *** DO NOT LAND *** Implement column-span:all without reparenting renderers. Work in progress.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderMultiColumnFlowThread.h

Issue 551263005: *** DO NOT LAND *** Implement column-span:all without reparenting renderers. Work in progress. (Closed) Base URL: git:blink.git@new-multicol-no-renderer-reparenting

Patch Set: Copy margin properties from a spanner to its spanner set, to simplify code. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Index: Source/core/rendering/RenderMultiColumnFlowThread.h

diff --git a/Source/core/rendering/RenderMultiColumnFlowThread.h b/Source/core/rendering/RenderMultiColumnFlowThread.h

index cf36649f763f36e0c7d69aa5a16c24a7f3ffbd76..a0347f529021dffa437e9748576b3b5cbf2b13d6 100644

--- a/Source/core/rendering/RenderMultiColumnFlowThread.h

+++ b/Source/core/rendering/RenderMultiColumnFlowThread.h

@@ -149,11 +149,11 @@ private:

virtual void addRegionToThread(RenderMultiColumnSet*) OVERRIDE;

virtual void willBeRemovedFromTree() OVERRIDE;

virtual bool hasColumnSpanner(const RenderObject*) const OVERRIDE;

- virtual LayoutUnit spannerLogicalTopAdjustment(RenderBox* renderer, LayoutUnit logicalTop) const OVERRIDE;

- virtual void enterColumnSpanner(RenderBox*, LayoutUnit& logicalTop) OVERRIDE;

+ virtual LayoutUnit enterColumnSpanner(RenderBox*, LayoutUnit logicalTop) OVERRIDE;

virtual void leaveColumnSpanner(RenderBox*, LayoutUnit logicalBottom) OVERRIDE;

virtual void flowThreadDescendantInserted(RenderObject*) OVERRIDE;

virtual void flowThreadDescendantWillBeRemoved(RenderObject*) OVERRIDE;

+ virtual void flowThreadDescendantStyleDidChange(RenderObject*) OVERRIDE;

virtual void computeLogicalHeight(LayoutUnit logicalHeight, LayoutUnit logicalTop, LogicalExtentComputedValues&) const OVERRIDE;

virtual void updateLogicalWidth() OVERRIDE;

virtual void setPageBreak(LayoutUnit offset, LayoutUnit spaceShortage) OVERRIDE;

« no previous file with comments | « Source/core/rendering/RenderFlowThread.h ('k') | Source/core/rendering/RenderMultiColumnFlowThread.cpp » ('j') | no next file with comments »