Source/core/rendering/RenderFlowThread.h - Issue 551263005: *** DO NOT LAND *** Implement column-span:all without reparenting renderers. Work in progress.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderFlowThread.h

Issue 551263005: *** DO NOT LAND *** Implement column-span:all without reparenting renderers. Work in progress. (Closed) Base URL: git:blink.git@new-multicol-no-renderer-reparenting

Patch Set: Copy margin properties from a spanner to its spanner set, to simplify code. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderFlowThread.h

diff --git a/Source/core/rendering/RenderFlowThread.h b/Source/core/rendering/RenderFlowThread.h

index d7770740d7fde73d06e14cbf662074f1f72c192a..451388d2783ec761f918a6eb07db0bc7c98c0c58 100644

--- a/Source/core/rendering/RenderFlowThread.h

+++ b/Source/core/rendering/RenderFlowThread.h

@@ -68,11 +68,11 @@ public:

virtual LayerType layerTypeRequired() const OVERRIDE FINAL { return NormalLayer; }

virtual bool hasColumnSpanner(const RenderObject*) const { return false; }

- virtual LayoutUnit spannerLogicalTopAdjustment(RenderBox* renderer, LayoutUnit logicalTop) const { return LayoutUnit(); }

- virtual void enterColumnSpanner(RenderBox*, LayoutUnit& logicalTop) { }

+ virtual LayoutUnit enterColumnSpanner(RenderBox*, LayoutUnit logicalTop) { return LayoutUnit(); }

virtual void leaveColumnSpanner(RenderBox*, LayoutUnit logicalBottom) { }

virtual void flowThreadDescendantInserted(RenderObject*) { }

virtual void flowThreadDescendantWillBeRemoved(RenderObject*) { }

+ virtual void flowThreadDescendantStyleDidChange(RenderObject*) { }

virtual bool nodeAtPoint(const HitTestRequest&, HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, HitTestAction) OVERRIDE FINAL;

« no previous file with comments | « Source/core/rendering/RenderBox.cpp ('k') | Source/core/rendering/RenderMultiColumnFlowThread.h » ('j') | no next file with comments »