Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Side by Side Diff: Source/core/rendering/RenderFlowThread.h

Issue 551263005: *** DO NOT LAND *** Implement column-span:all without reparenting renderers. Work in progress. (Closed) Base URL: git:blink.git@new-multicol-no-renderer-reparenting
Patch Set: Copy margin properties from a spanner to its spanner set, to simplify code. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved. 2 * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above 8 * 1. Redistributions of source code must retain the above
9 * copyright notice, this list of conditions and the following 9 * copyright notice, this list of conditions and the following
10 * disclaimer. 10 * disclaimer.
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 virtual bool isRenderMultiColumnFlowThread() const { return false; } 61 virtual bool isRenderMultiColumnFlowThread() const { return false; }
62 virtual bool isRenderPagedFlowThread() const { return false; } 62 virtual bool isRenderPagedFlowThread() const { return false; }
63 63
64 virtual void layout() OVERRIDE; 64 virtual void layout() OVERRIDE;
65 65
66 // Always create a RenderLayer for the RenderFlowThread so that we 66 // Always create a RenderLayer for the RenderFlowThread so that we
67 // can easily avoid drawing the children directly. 67 // can easily avoid drawing the children directly.
68 virtual LayerType layerTypeRequired() const OVERRIDE FINAL { return NormalLa yer; } 68 virtual LayerType layerTypeRequired() const OVERRIDE FINAL { return NormalLa yer; }
69 69
70 virtual bool hasColumnSpanner(const RenderObject*) const { return false; } 70 virtual bool hasColumnSpanner(const RenderObject*) const { return false; }
71 virtual LayoutUnit spannerLogicalTopAdjustment(RenderBox* renderer, LayoutUn it logicalTop) const { return LayoutUnit(); } 71 virtual LayoutUnit enterColumnSpanner(RenderBox*, LayoutUnit logicalTop) { r eturn LayoutUnit(); }
72 virtual void enterColumnSpanner(RenderBox*, LayoutUnit& logicalTop) { }
73 virtual void leaveColumnSpanner(RenderBox*, LayoutUnit logicalBottom) { } 72 virtual void leaveColumnSpanner(RenderBox*, LayoutUnit logicalBottom) { }
74 virtual void flowThreadDescendantInserted(RenderObject*) { } 73 virtual void flowThreadDescendantInserted(RenderObject*) { }
75 virtual void flowThreadDescendantWillBeRemoved(RenderObject*) { } 74 virtual void flowThreadDescendantWillBeRemoved(RenderObject*) { }
75 virtual void flowThreadDescendantStyleDidChange(RenderObject*) { }
76 76
77 virtual bool nodeAtPoint(const HitTestRequest&, HitTestResult&, const HitTes tLocation& locationInContainer, const LayoutPoint& accumulatedOffset, HitTestAct ion) OVERRIDE FINAL; 77 virtual bool nodeAtPoint(const HitTestRequest&, HitTestResult&, const HitTes tLocation& locationInContainer, const LayoutPoint& accumulatedOffset, HitTestAct ion) OVERRIDE FINAL;
78 78
79 virtual void addRegionToThread(RenderMultiColumnSet*) = 0; 79 virtual void addRegionToThread(RenderMultiColumnSet*) = 0;
80 virtual void removeRegionFromThread(RenderMultiColumnSet*); 80 virtual void removeRegionFromThread(RenderMultiColumnSet*);
81 81
82 virtual void computeLogicalHeight(LayoutUnit logicalHeight, LayoutUnit logic alTop, LogicalExtentComputedValues&) const OVERRIDE; 82 virtual void computeLogicalHeight(LayoutUnit logicalHeight, LayoutUnit logic alTop, LogicalExtentComputedValues&) const OVERRIDE;
83 83
84 bool hasRegions() const { return m_multiColumnSetList.size(); } 84 bool hasRegions() const { return m_multiColumnSetList.size(); }
85 85
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
221 }; 221 };
222 222
223 template <> struct ValueToString<RenderMultiColumnSet*> { 223 template <> struct ValueToString<RenderMultiColumnSet*> {
224 static String string(const RenderMultiColumnSet* value) { return String::for mat("%p", value); } 224 static String string(const RenderMultiColumnSet* value) { return String::for mat("%p", value); }
225 }; 225 };
226 #endif 226 #endif
227 227
228 } // namespace blink 228 } // namespace blink
229 229
230 #endif // RenderFlowThread_h 230 #endif // RenderFlowThread_h
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderBox.cpp ('k') | Source/core/rendering/RenderMultiColumnFlowThread.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698