Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Issue 550763002: Revert of [Mac] Shut down connections to WindowServer before engaging the sandbox. (Closed)

Created:
6 years, 3 months ago by Noel Gordon
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of [Mac] Shut down connections to WindowServer before engaging the sandbox. (patchset #1 id:1 of https://codereview.chromium.org/545603002/) Reason for revert: Speculative revert: seems this change caused 135 layout tests failures on the webkit mac builders, from OSX 10.6-10.9 http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6%20%28deps%29/builds/30830 Original issue's description: > [Mac] Shut down connections to WindowServer before engaging the sandbox. > > The connection is only needed during sandbox warmup to initialize the default > color space. It was formerly needed by scrollbar NSAnimations, but that was > replaced via https://codereview.chromium.org/529103002/. > > BUG=397642, 306348 > TEST=Manually tested on 10.6-10.10. > R=avi@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/d9707172e540487d14c53363c5d1c2151999c2d8 TBR=avi@chromium.org,rsesek@chromium.org NOTREECHECKS=true NOTRY=true BUG=397642, 306348 Committed: https://crrev.com/53ffdf90f4646dbde8df72007fbdc97f3f0220de Cr-Commit-Position: refs/heads/master@{#293653}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M content/renderer/renderer_main_platform_delegate_mac.mm View 2 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Noel Gordon
Created Revert of [Mac] Shut down connections to WindowServer before engaging the sandbox.
6 years, 3 months ago (2014-09-07 04:32:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noel@chromium.org/550763002/1
6 years, 3 months ago (2014-09-07 04:37:27 UTC) #2
Noel Gordon
6 years, 3 months ago (2014-09-07 04:37:42 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as e5378866e27fa3900d7359bc3b64bc363f2e3cd2
6 years, 3 months ago (2014-09-07 04:40:31 UTC) #4
Noel Gordon
For the record, the 135 failing tests went green after this revert.
6 years, 3 months ago (2014-09-07 13:21:40 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:43:56 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/53ffdf90f4646dbde8df72007fbdc97f3f0220de
Cr-Commit-Position: refs/heads/master@{#293653}

Powered by Google App Engine
This is Rietveld 408576698