[Mac] Shut down connections to WindowServer before engaging the sandbox.

[Mac] Shut down connections to WindowServer before engaging the sandbox.

The connection is only needed during sandbox warmup to initialize the default
color space. It was formerly needed by scrollbar NSAnimations, but that was
replaced via https://codereview.chromium.org/529103002/.

BUG=397642, 306348
TEST=Manually tested on 10.6-10.10.
R=avi@chromium.org

Committed: https://crrev.com/a602902631a762be0b49ac0af09de0c9c840e183
Cr-Commit-Position: refs/heads/master@{#293546}

[Avi (use Gerrit), 2014-09-04 20:10:54]

LGTM

https://codereview.chromium.org/545603002/diff/1/content/renderer/renderer_ma...
File content/renderer/renderer_main_platform_delegate_mac.mm (right):

https://codereview.chromium.org/545603002/diff/1/content/renderer/renderer_ma...
content/renderer/renderer_main_platform_delegate_mac.mm:146: // connecting to
WindowServer, so do this before engaging the sandbox.
"It's like having to connect to the WindowServer to shut down the connection to
the WindowServer"

[Robert Sesek, 2014-09-05 16:22:59]

The CQ bit was checked by rsesek@chromium.org

[commit-bot: I haz the power, 2014-09-05 16:24:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rsesek@chromium.org/545603002/1

[commit-bot: I haz the power, 2014-09-05 17:27:54]

Committed patchset #1 (id:1) as d9707172e540487d14c53363c5d1c2151999c2d8

[Noel Gordon, 2014-09-07 04:32:39]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/550763002/ by noel@chromium.org.

The reason for reverting is: Speculative revert: seems this change caused 135
layout tests failures on the webkit mac builders, from OSX 10.6-10.9

http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6%20%28de...
.

[Noel Gordon, 2014-09-07 05:50:29]

On 2014/09/07 04:32:39, Noel Gordon wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/550763002/ by mailto:noel@chromium.org.
> 
> The reason for reverting is: Speculative revert: seems this change caused 135
> layout tests failures on the webkit mac builders, from OSX 10.6-10.9
> 
>
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6%20%28de...
>

and 171 layout test failures on 10.8 (retina) for the record.

http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.8%20%28re...

[commit-bot: I haz the power, 2014-09-10 03:40:23]

Patchset 1 (id:??) landed as
https://crrev.com/a602902631a762be0b49ac0af09de0c9c840e183
Cr-Commit-Position: refs/heads/master@{#293546}