Issue 54983011: "Reverting 29728"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 54983011: "Reverting 29728" (Closed)

Created:
7 years, 1 month ago by Jennifer Messerly

Modified:
7 years, 1 month ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org, kasperl

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

"Reverting 29728" I changed the test to avoid using mirrors. Somehow, import mirrors exposes a strange dart2js interceptor bug, but only in unchecked mode. (I only ran checked mode in my local tests :|. Doh) Needs more investigation, but what seems to be happening: * setInnerHtml creates a document * it tries to append <base> to the <head> * interceptor gets "Document" instead of "HtmlDocument" * so the `document.head` fails The bug seems to require Shadow DOM+unchecked+mirrors. Anyway, since it's totally unrelated to this test or the bug fix for 14700, I'm just working around it for now. Will open a separate issue. R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=29767

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+66 lines, -10 lines)			Patch
M	pkg/pkg.status	View	2 chunks	+2 lines, -0 lines	0 comments	Download
A	pkg/polymer/test/nested_binding_test.dart	View	1 chunk	+39 lines, -0 lines	0 comments	Download
A +	pkg/polymer/test/nested_binding_test.html	View	1 chunk	+14 lines, -10 lines	0 comments	Download
M	pkg/polymer_expressions/lib/polymer_expressions.dart	View	1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

the other issue is: https://code.google.com/p/dart/issues/detail?id=14720

7 years, 1 month ago (2013-11-01 19:22:19 UTC) #2

Jennifer Messerly

7 years, 1 month ago (2013-11-01 19:59:57 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r29767 (presubmit successful).

Expand Messages | Collapse Messages