Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: pkg/polymer_expressions/lib/polymer_expressions.dart

Issue 54983011: "Reverting 29728" (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/polymer/test/nested_binding_test.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/polymer_expressions/lib/polymer_expressions.dart
diff --git a/pkg/polymer_expressions/lib/polymer_expressions.dart b/pkg/polymer_expressions/lib/polymer_expressions.dart
index 354fb5eb9958bf2100874438a16afe1e56b1ab63..0d4d06192fe05ad9292a8e0f768e7f5b427f2d3e 100644
--- a/pkg/polymer_expressions/lib/polymer_expressions.dart
+++ b/pkg/polymer_expressions/lib/polymer_expressions.dart
@@ -70,6 +70,17 @@ class PolymerExpressions extends BindingDelegate {
prepareBinding(String path, name, node) {
if (path == null) return null;
var expr = new Parser(path).parse();
+
+ // For template bind/repeat to an empty path, just pass through the model.
+ // We don't want to unwrap the Scope.
+ // TODO(jmesserly): a custom element extending <template> could notice this
+ // behavior. An alternative is to associate the Scope with the node via an
+ // Expando, which is what the JavaScript PolymerExpressions does.
+ if (isSemanticTemplate(node) && (name == 'bind' || name == 'repeat') &&
+ expr is EmptyExpression) {
+ return null;
+ }
+
return (model, node) {
if (model is! Scope) {
model = new Scope(model: model, variables: globals);
« no previous file with comments | « pkg/polymer/test/nested_binding_test.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698