Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Issue 54983011: "Reverting 29728" (Closed)

Created:
7 years, 1 month ago by Jennifer Messerly
Modified:
7 years, 1 month ago
CC:
reviews_dartlang.org, kasperl
Visibility:
Public.

Description

"Reverting 29728" I changed the test to avoid using mirrors. Somehow, import mirrors exposes a strange dart2js interceptor bug, but only in unchecked mode. (I only ran checked mode in my local tests :|. Doh) Needs more investigation, but what seems to be happening: * setInnerHtml creates a document * it tries to append <base> to the <head> * interceptor gets "Document" instead of "HtmlDocument" * so the `document.head` fails The bug seems to require Shadow DOM+unchecked+mirrors. Anyway, since it's totally unrelated to this test or the bug fix for 14700, I'm just working around it for now. Will open a separate issue. R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=29767

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -10 lines) Patch
M pkg/pkg.status View 2 chunks +2 lines, -0 lines 0 comments Download
A pkg/polymer/test/nested_binding_test.dart View 1 chunk +39 lines, -0 lines 0 comments Download
A + pkg/polymer/test/nested_binding_test.html View 1 chunk +14 lines, -10 lines 0 comments Download
M pkg/polymer_expressions/lib/polymer_expressions.dart View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Jennifer Messerly
7 years, 1 month ago (2013-11-01 19:19:58 UTC) #1
Jennifer Messerly
the other issue is: https://code.google.com/p/dart/issues/detail?id=14720
7 years, 1 month ago (2013-11-01 19:22:19 UTC) #2
Siggi Cherem (dart-lang)
that's so bizarre
7 years, 1 month ago (2013-11-01 19:59:00 UTC) #3
Siggi Cherem (dart-lang)
lgtm
7 years, 1 month ago (2013-11-01 19:59:05 UTC) #4
Jennifer Messerly
7 years, 1 month ago (2013-11-01 19:59:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r29767 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698