Windows: Fix the plugin metadata check to determine if Adobe Reader is secure.

Windows: Fix the plugin metadata check to determine if Adobe Reader is secure.

BUG=412242
TEST=manual, see bug.

Committed: https://crrev.com/e7f09286e16fef6a8646a1c630f88f65cf225b5f
Cr-Commit-Position: refs/heads/master@{#294034}

[Lei Zhang, 2014-09-09 05:50:38]

thestig@chromium.org changed reviewers:
+ bauerb@chromium.org, cevans@chromium.org

[Bernhard Bauer, 2014-09-09 08:22:37]

LGTM w/ a suggestion:

https://codereview.chromium.org/549313003/diff/1/chrome/browser/ui/pdf/adobe_...
File chrome/browser/ui/pdf/adobe_reader_info_win.cc (right):

https://codereview.chromium.org/549313003/diff/1/chrome/browser/ui/pdf/adobe_...
chrome/browser/ui/pdf/adobe_reader_info_win.cc:102: security_stat ==
PluginMetadata::SECURITY_STATUS_UP_TO_DATE ||
Change this directly to != SECURITY_STATUS_OUT_OF_DATE? That's what this check
is really about.

[Lei Zhang, 2014-09-09 18:26:35]

https://codereview.chromium.org/549313003/diff/1/chrome/browser/ui/pdf/adobe_...
File chrome/browser/ui/pdf/adobe_reader_info_win.cc (right):

https://codereview.chromium.org/549313003/diff/1/chrome/browser/ui/pdf/adobe_...
chrome/browser/ui/pdf/adobe_reader_info_win.cc:102: security_stat ==
PluginMetadata::SECURITY_STATUS_UP_TO_DATE ||
On 2014/09/09 08:22:37, Bernhard Bauer wrote:
> Change this directly to != SECURITY_STATUS_OUT_OF_DATE? That's what this check
> is really about.

I want to be explicitly about it. In case someone adds
"SECURITY_STATUS_REALLY_BAD_VERSION", I don't want that to flip |is_secure| to
true.

[Lei Zhang, 2014-09-09 18:26:39]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-09-09 18:39:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/549313003/1

[commit-bot: I haz the power, 2014-09-09 21:23:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-09 21:23:48]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[Lei Zhang, 2014-09-09 21:25:55]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-09-09 21:31:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/549313003/1

[commit-bot: I haz the power, 2014-09-09 23:34:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-09 23:34:33]

Failed to commit the patch.

[commit-bot: I haz the power, 2014-09-10 03:56:29]

Patchset 1 (id:??) landed as
https://crrev.com/e7f09286e16fef6a8646a1c630f88f65cf225b5f
Cr-Commit-Position: refs/heads/master@{#294034}