Windows: Fix the plugin metadata check to determine if Adobe Reader is secure.

chrome/browser/ui/pdf/adobe_reader_info_win.cc

Index: chrome/browser/ui/pdf/adobe_reader_info_win.cc
diff --git a/chrome/browser/ui/pdf/adobe_reader_info_win.cc b/chrome/browser/ui/pdf/adobe_reader_info_win.cc
index dee3a1c51dc97e47e403a0d76ca0256fcd5421e6..9552e59f209d5423d20d967c72519a6962c513a7 100644
--- a/chrome/browser/ui/pdf/adobe_reader_info_win.cc
+++ b/chrome/browser/ui/pdf/adobe_reader_info_win.cc
@@ -94,10 +94,13 @@ AdobeReaderPluginInfo GetReaderPlugin(
       reader_info.is_enabled = plugin_status != PluginPrefs::POLICY_DISABLED;
     }
 
-    PluginMetadata::SecurityStatus security_status =
+    // Adobe Reader will likely always come up as "requires_authorization".
+    // See http://crbug.com/311655.
+    PluginMetadata::SecurityStatus security_stat =
         plugin_metadata->GetSecurityStatus(plugins[i]);
     reader_info.is_secure =
-        security_status == PluginMetadata::SECURITY_STATUS_UP_TO_DATE;
+        security_stat == PluginMetadata::SECURITY_STATUS_UP_TO_DATE ||

[Bernhard Bauer, 2014/09/09 08:22:37]

Change this directly to != SECURITY_STATUS_OUT_OF_DATE? That's what this check
is really about.

[Lei Zhang, 2014/09/09 18:26:35]

I want to be explicitly about it. In case someone adds
"SECURITY_STATUS_REALLY_BAD_VERSION", I don't want that to flip |is_secure| to
true.

+        security_stat == PluginMetadata::SECURITY_STATUS_REQUIRES_AUTHORIZATION;
 
     reader_info.plugin_info = plugins[i];
     break;