Windows: Fix the plugin metadata check to determine if Adobe Reader is secure.

chrome/browser/ui/pdf/adobe_reader_info_win.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/pdf/adobe_reader_info_win.h"
 
 #include <shlwapi.h>
 
 #include <algorithm>
 #include <vector>
@@ skipping 76 matching lines @@
 
     reader_info.is_installed = true;
 
     if (profile) {
       PluginPrefs* plugin_prefs = PluginPrefs::GetForProfile(profile);
       PluginPrefs::PolicyStatus plugin_status =
           plugin_prefs->PolicyStatusForPlugin(plugin_metadata->name());
       reader_info.is_enabled = plugin_status != PluginPrefs::POLICY_DISABLED;
     }
 
-    PluginMetadata::SecurityStatus security_status =
+    // Adobe Reader will likely always come up as "requires_authorization".
+    // See http://crbug.com/311655.
+    PluginMetadata::SecurityStatus security_stat =
         plugin_metadata->GetSecurityStatus(plugins[i]);
     reader_info.is_secure =
-        security_status == PluginMetadata::SECURITY_STATUS_UP_TO_DATE;
+        security_stat == PluginMetadata::SECURITY_STATUS_UP_TO_DATE ||

[Bernhard Bauer, 2014/09/09 08:22:37]

Change this directly to != SECURITY_STATUS_OUT_OF_DATE? That's what this check
is really about.

[Lei Zhang, 2014/09/09 18:26:35]

I want to be explicitly about it. In case someone adds
"SECURITY_STATUS_REALLY_BAD_VERSION", I don't want that to flip |is_secure| to
true.

+        security_stat == PluginMetadata::SECURITY_STATUS_REQUIRES_AUTHORIZATION;
 
     reader_info.plugin_info = plugins[i];
     break;
   }
   return reader_info;
 }
 
 void OnGotPluginInfo(Profile* profile,
                      const GetAdobeReaderPluginInfoCallback& callback,
                      const std::vector<content::WebPluginInfo>& plugins) {
@@ skipping 63 matching lines @@
       base::UTF16ToUTF8(file_version_info->product_version());
   // Convert 1.2.03.45 to 1.2.3.45 so base::Version considers it as valid.
   for (int i = 1; i <= 9; ++i) {
     std::string from = base::StringPrintf(".0%d", i);
     std::string to = base::StringPrintf(".%d", i);
     ReplaceSubstringsAfterOffset(&reader_version, 0, from, to);
   }
   base::Version file_version(reader_version);
   return file_version.IsValid() && !file_version.IsOlderThan(kSecureVersion);
 }