Dev finch trial of the data reduction proxy overrides both the primary and the fallback hosts

Make the DataCompressionProxyDevRollout trial be able to override both the primary host and the fallback host of the data reduction proxy.

Related Chrome Android CL: 
https://chrome-internal-review.googlesource.com/#/c/175697/

BUG=410961
Committed: https://crrev.com/098fc170c44d55377d0d79fafc98f095ed484b23
Cr-Commit-Position: refs/heads/master@{#294035}

[bolian, 2014-09-09 00:39:20]

Patchset #1 (id:1) has been deleted

[bolian, 2014-09-09 00:41:27]

bolian@chromium.org changed reviewers:
+ bengr@chromium.org

[bolian, 2014-09-09 00:45:06]

Patchset #1 (id:10005) has been deleted

[bengr, 2014-09-09 19:17:57]

lgtm with nits. Also, please add more thorough description for the CL.

https://codereview.chromium.org/549153003/diff/50001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/549153003/diff/50001/build/common.gypi#newcod...
build/common.gypi:978: 'data_reduction_dev_host%':
'https://proxy-dev.googlezip.net:443/',
Please coordinate with kundaji@ as he's updating how the DNS names get plumbed.

https://codereview.chromium.org/549153003/diff/50001/components/data_reductio...
File components/data_reduction_proxy/browser/data_reduction_proxy_params.cc
(right):

https://codereview.chromium.org/549153003/diff/50001/components/data_reductio...
components/data_reduction_proxy/browser/data_reduction_proxy_params.cc:408:
kEnabled)) {
indent 2 more, or move "DataCompressionProxyDevRollout... down to this line and
indent 2 more.

https://codereview.chromium.org/549153003/diff/50001/components/data_reductio...
File
components/data_reduction_proxy/browser/data_reduction_proxy_params_test_utils.h
(right):

https://codereview.chromium.org/549153003/diff/50001/components/data_reductio...
components/data_reduction_proxy/browser/data_reduction_proxy_params_test_utils.h:51:
virtual std::string GetDefaultDevFallbackOrigin() const OVERRIDE;
Add a blank line above

https://codereview.chromium.org/549153003/diff/50001/components/data_reductio...
File
components/data_reduction_proxy/browser/data_reduction_proxy_params_unittest.cc
(right):

https://codereview.chromium.org/549153003/diff/50001/components/data_reductio...
components/data_reduction_proxy/browser/data_reduction_proxy_params_unittest.cc:439:
EXPECT_EQ(tests[i].expected_result, params.init_result()) << i;
Why is '<< i' needed, here and below?

[bengr, 2014-09-09 19:18:42]

bengr@chromium.org changed reviewers:
+ kundaji@chromium.org

[bengr, 2014-09-09 19:18:43]

Adding kundaji@ to double check the change as he is moving things around.

[Not at Google. Contact bengr, 2014-09-09 19:41:41]

lgtm

https://codereview.chromium.org/549153003/diff/50001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/549153003/diff/50001/build/common.gypi#newcod...
build/common.gypi:978: 'data_reduction_dev_host%':
'https://proxy-dev.googlezip.net:443/',
On 2014/09/09 19:17:56, bengr1 wrote:
> Please coordinate with kundaji@ as he's updating how the DNS names get
plumbed.

Thanks for letting me know. I'll update the all-platforms cl.

[bolian, 2014-09-09 20:32:51]

Thanks for the review!

https://codereview.chromium.org/549153003/diff/50001/components/data_reductio...
File components/data_reduction_proxy/browser/data_reduction_proxy_params.cc
(right):

https://codereview.chromium.org/549153003/diff/50001/components/data_reductio...
components/data_reduction_proxy/browser/data_reduction_proxy_params.cc:408:
kEnabled)) {
On 2014/09/09 19:17:56, bengr1 wrote:
> indent 2 more, or move "DataCompressionProxyDevRollout... down to this line
and
> indent 2 more.

Done.

https://codereview.chromium.org/549153003/diff/50001/components/data_reductio...
File
components/data_reduction_proxy/browser/data_reduction_proxy_params_test_utils.h
(right):

https://codereview.chromium.org/549153003/diff/50001/components/data_reductio...
components/data_reduction_proxy/browser/data_reduction_proxy_params_test_utils.h:51:
virtual std::string GetDefaultDevFallbackOrigin() const OVERRIDE;
On 2014/09/09 19:17:56, bengr1 wrote:
> Add a blank line above

Done.

https://codereview.chromium.org/549153003/diff/50001/components/data_reductio...
File
components/data_reduction_proxy/browser/data_reduction_proxy_params_unittest.cc
(right):

https://codereview.chromium.org/549153003/diff/50001/components/data_reductio...
components/data_reduction_proxy/browser/data_reduction_proxy_params_unittest.cc:439:
EXPECT_EQ(tests[i].expected_result, params.init_result()) << i;
On 2014/09/09 19:17:56, bengr1 wrote:
> Why is '<< i' needed, here and below?

So that I know which one fails when it does.

[bolian, 2014-09-09 20:38:07]

Related Chrome Android CL:
https://chrome-internal-review.googlesource.com/#/c/175725/

[bolian, 2014-09-09 21:01:39]

The CQ bit was checked by bolian@chromium.org

[commit-bot: I haz the power, 2014-09-09 21:22:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bolian@chromium.org/549153003/70001

[commit-bot: I haz the power, 2014-09-09 22:12:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-09 22:12:53]

Try jobs failed on following builders:
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[bolian, 2014-09-09 22:22:34]

The CQ bit was checked by bolian@chromium.org

[commit-bot: I haz the power, 2014-09-09 22:23:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bolian@chromium.org/549153003/70001

[commit-bot: I haz the power, 2014-09-09 23:35:43]

Committed patchset #3 (id:70001) as 683fda1fd01e7344d35b7d4aa3a1a8681bfe2497

[commit-bot: I haz the power, 2014-09-10 03:56:31]

Patchset 3 (id:??) landed as
https://crrev.com/098fc170c44d55377d0d79fafc98f095ed484b23
Cr-Commit-Position: refs/heads/master@{#294035}