components/data_reduction_proxy/browser/data_reduction_proxy_params_test_utils.h - Issue 549153003: Dev finch trial of the data reduction proxy overrides both the primary and the fallback hosts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/browser/data_reduction_proxy_params_test_utils.h

Issue 549153003: Dev finch trial of the data reduction proxy overrides both the primary and the fallback hosts (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed comments. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/browser/data_reduction_proxy_params.cc ('k') | components/data_reduction_proxy/browser/data_reduction_proxy_params_test_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/browser/data_reduction_proxy_params_test_utils.h

diff --git a/components/data_reduction_proxy/browser/data_reduction_proxy_params_test_utils.h b/components/data_reduction_proxy/browser/data_reduction_proxy_params_test_utils.h

index df804bfe0428a4d54800347221f7ac05c2e83e33..c0427edf5a792750c34ed3e61845cc48a6b9f25d 100644

--- a/components/data_reduction_proxy/browser/data_reduction_proxy_params_test_utils.h

+++ b/components/data_reduction_proxy/browser/data_reduction_proxy_params_test_utils.h

@@ -21,6 +21,7 @@ class TestDataReductionProxyParams : public DataReductionProxyParams {

HAS_ALT_ORIGIN = 0x10,

HAS_ALT_FALLBACK_ORIGIN = 0x20,

HAS_PROBE_URL = 0x40,

+ HAS_DEV_FALLBACK_ORIGIN = 0x80,

HAS_EVERYTHING = 0xff,

};

@@ -30,6 +31,7 @@ class TestDataReductionProxyParams : public DataReductionProxyParams {

// Test values to replace the values specified in preprocessor defines.

static std::string DefaultDevOrigin();

+ static std::string DefaultDevFallbackOrigin();

static std::string DefaultOrigin();

static std::string DefaultFallbackOrigin();

static std::string DefaultSSLOrigin();

@@ -47,6 +49,8 @@ class TestDataReductionProxyParams : public DataReductionProxyParams {

protected:

virtual std::string GetDefaultDevOrigin() const OVERRIDE;

+ virtual std::string GetDefaultDevFallbackOrigin() const OVERRIDE;

virtual std::string GetDefaultOrigin() const OVERRIDE;

virtual std::string GetDefaultFallbackOrigin() const OVERRIDE;