components/data_reduction_proxy/browser/data_reduction_proxy_protocol_unittest.cc - Issue 549153003: Dev finch trial of the data reduction proxy overrides both the primary and the fallback hosts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/browser/data_reduction_proxy_protocol_unittest.cc

Issue 549153003: Dev finch trial of the data reduction proxy overrides both the primary and the fallback hosts (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed comments. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/browser/data_reduction_proxy_params_unittest.cc ('k') | components/data_reduction_proxy/browser/data_reduction_proxy_settings_test_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/browser/data_reduction_proxy_protocol_unittest.cc

diff --git a/components/data_reduction_proxy/browser/data_reduction_proxy_protocol_unittest.cc b/components/data_reduction_proxy/browser/data_reduction_proxy_protocol_unittest.cc

index 0e3b2377311ace47635803c4ec4e4934e9c59f9c..3c81063ac0ba4672456a55bd9c5a7be3ccc9e28a 100644

--- a/components/data_reduction_proxy/browser/data_reduction_proxy_protocol_unittest.cc

+++ b/components/data_reduction_proxy/browser/data_reduction_proxy_protocol_unittest.cc

@@ -95,7 +95,8 @@ class DataReductionProxyProtocolTest : public testing::Test {

DataReductionProxyParams::kFallbackAllowed |

DataReductionProxyParams::kPromoAllowed,

TestDataReductionProxyParams::HAS_EVERYTHING &

- ~TestDataReductionProxyParams::HAS_DEV_ORIGIN));

+ ~TestDataReductionProxyParams::HAS_DEV_ORIGIN &

+ ~TestDataReductionProxyParams::HAS_DEV_FALLBACK_ORIGIN));

}

// Sets up the |TestURLRequestContext| with the provided |ProxyService| and

@@ -791,7 +792,8 @@ TEST_F(DataReductionProxyProtocolTest, OnResolveProxyHandler) {

DataReductionProxyParams::kFallbackAllowed |

DataReductionProxyParams::kPromoAllowed,

TestDataReductionProxyParams::HAS_EVERYTHING &

- ~TestDataReductionProxyParams::HAS_DEV_ORIGIN);

+ ~TestDataReductionProxyParams::HAS_DEV_ORIGIN &

+ ~TestDataReductionProxyParams::HAS_DEV_FALLBACK_ORIGIN);

// Data reduction proxy info

net::ProxyInfo data_reduction_proxy_info;